From: Mike Frysinger <vapier@gentoo.org>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: "Ted Ts'o" <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: libquota: add a quotactl prototype
Date: Mon, 28 May 2012 20:37:49 -0400 [thread overview]
Message-ID: <201205282037.50920.vapier@gentoo.org> (raw)
In-Reply-To: <9479769F-26BE-415D-804A-4766736ACEF5@whamcloud.com>
[-- Attachment #1: Type: Text/Plain, Size: 842 bytes --]
On Monday 28 May 2012 11:31:42 Andreas Dilger wrote:
> On 2012-05-28, at 8:20, Ted Ts'o <tytso@mit.edu> wrote:
> > On Tue, May 22, 2012 at 09:41:29AM -0000, Mike Frysinger wrote:
> >> The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
> >> quota.h include, but in doing so, added the problem:
> >> mkquota.c:55:2: warning: implicit declaration of function 'quotactl'
> >>
> >> Since we're maintaining a copy of quota.h, add a proper func prototype.
> >>
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >
> > Thanks, applied.
>
> This patch caused a compile failure on my FC 13 system, when I had no
> problem before, because caddr_t was not defined...
your definition of "no problem" is different from mine. Ted's latest patch
works fine for me though -- punt the call completely.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-29 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 19:41 [PATCH] libquota: add a quotactl prototype Mike Frysinger
2012-05-28 14:20 ` Ted Ts'o
2012-05-28 14:45 ` Ted Ts'o
2012-05-28 15:31 ` Andreas Dilger
2012-05-29 0:37 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205282037.50920.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.