From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Walle Date: Mon, 28 May 2012 23:45:25 +0200 Subject: [U-Boot] [PATCH] Kirkwood: declare mpp config static and const In-Reply-To: <20120527212029.GA15012@w500.iskon.local> References: <1337992021-30571-1-git-send-email-michael@walle.cc> <20120527212029.GA15012@w500.iskon.local> Message-ID: <201205282345.25035.michael@walle.cc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Luka, Am Sonntag 27 Mai 2012, 23:20:29 schrieb Luka Perkov: > NACK. At least in this version. Please double check all the kirkwood > boards (taken from boards.cfg): ups sorry, actually my tree wasn't up to date :( pogo_e02 is missing, too. > diff --git a/board/raidsonic/ib62x0/ib62x0.c > b/board/raidsonic/ib62x0/ib62x0.c index 65f2c2e..f888901 100644 > --- a/board/raidsonic/ib62x0/ib62x0.c > +++ b/board/raidsonic/ib62x0/ib62x0.c > @@ -42,7 +42,7 @@ int board_early_init_f(void) > IB62x0_OE_LOW, IB62x0_OE_HIGH); > > /* Multi-Purpose Pins Functionality configuration */ > - u32 kwmpp_config[] = { > + static const kwmpp_config[] = { this should be static const u32 kwmpp_config[] = { > Also you should note that this patch should be applied after your > patches for lsxl board. ah yes, thanks. -- Michael