From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Kamil Grzebien <ciptok@gmail.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: Initializing iwl3945 error
Date: Tue, 29 May 2012 11:21:56 +0200 [thread overview]
Message-ID: <20120529092154.GA2441@redhat.com> (raw)
In-Reply-To: <CAErSpo6XVgzeQiWjXJs6vxdQ5_O7LFG-j4p=4S7rQSyBdq7-SA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Mon, May 28, 2012 at 12:21:34PM -0600, Bjorn Helgaas wrote:
> linked in vs. loaded as a module after boot? What if you add a long
> delay in the driver probe routine?
I'm attaching patch which add 200 ms delay after pci_enable_device() in
->probe routine.
Stanislaw
[-- Attachment #2: iwl3945_pci_probe_delay.patch --]
[-- Type: text/plain, Size: 445 bytes --]
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index faec404..96fe43d 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
@@ -3635,6 +3635,8 @@ il3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
goto out_ieee80211_free_hw;
}
+ msleep(200);
+
pci_set_master(pdev);
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
next prev parent reply other threads:[~2012-05-29 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 17:43 Initializing iwl3945 error Kamil Grzebien
2012-03-13 8:12 ` Stanislaw Gruszka
2012-03-15 21:08 ` Bjorn Helgaas
2012-04-04 16:13 ` Stanislaw Gruszka
2012-04-05 8:24 ` Kamil Grzebien
2012-04-08 11:51 ` Kamil Grzebien
2012-05-28 14:04 ` Stanislaw Gruszka
2012-05-28 18:21 ` Bjorn Helgaas
2012-05-29 9:21 ` Stanislaw Gruszka [this message]
2012-06-22 3:30 ` Bjorn Helgaas
2012-07-01 18:01 ` Kamil Grzebien
2012-07-02 5:31 ` Stanislaw Gruszka
2012-07-02 20:49 ` Kamil Grzebien
2012-07-06 20:38 ` Bjorn Helgaas
2012-07-06 21:34 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529092154.GA2441@redhat.com \
--to=sgruszka@redhat.com \
--cc=bhelgaas@google.com \
--cc=ciptok@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.