All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tony Luck <tony.luck@intel.com>,
	mingo@kernel.org, torvalds@linux-foundation.org,
	cmetcalf@tilera.com, sivanich@sgi.com, akpm@linux-foundation.org,
	ralf@linux-mips.org, greg.pearson@hp.com,
	ink@jurassic.park.msu.ru, tglx@linutronix.de, rth@twiddle.net,
	kamezawa.hiroyu@jp.fujitsu.com, paulus@samba.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com, lethal@linux-sh.org,
	davem@davemloft.net, benh@kernel.crashing.org,
	dhowells@redhat.com, mattst88@gmail.com, fenghua.yu@intel.com,
	shangw@linux.vnet.ibm.com
Subject: Re: [tip:sched/core] sched/numa: Rewrite the CONFIG_NUMA sched domain support
Date: Tue, 29 May 2012 10:19:37 +1000	[thread overview]
Message-ID: <20120529101937.70ef0bf1@kryten> (raw)
In-Reply-To: <1337931080.9783.154.camel@laptop>


Hi Peter,

We have a number of ppc64 boxes that are hitting this and have
verified that the patch fixes it.

Tested-by: Anton Blanchard <anton@samba.org>

Thanks!
Anton

---
Subject: sched: Don't try allocating memory from offline nodes
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Fri May 25 09:26:43 CEST 2012

Allocators don't appreciate it when you try and allocate memory from
offline nodes.

Reported-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 kernel/sched/core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/kernel/sched/core.c
===================================================================
--- linux-2.6.orig/kernel/sched/core.c
+++ linux-2.6/kernel/sched/core.c
@@ -6449,7 +6449,7 @@ static void sched_init_numa(void)
 			return;
 
 		for (j = 0; j < nr_node_ids; j++) {
-			struct cpumask *mask = kzalloc_node(cpumask_size(), GFP_KERNEL, j);
+			struct cpumask *mask = kzalloc(cpumask_size(), GFP_KERNEL);
 			if (!mask)
 				return;
 



  parent reply	other threads:[~2012-05-29  0:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 14:29 [tip:sched/core] sched/numa: Rewrite the CONFIG_NUMA sched domain support tip-bot for Peter Zijlstra
2012-05-10 17:30 ` Yinghai Lu
2012-05-10 17:44   ` Peter Zijlstra
2012-05-10 17:54     ` Yinghai Lu
2012-05-29  0:32       ` Jiang Liu
2012-05-29 12:13         ` Peter Zijlstra
2012-05-29 17:12         ` Yinghai Lu
2012-05-24 21:23 ` Tony Luck
2012-05-25  7:31   ` Peter Zijlstra
2012-05-25 14:24     ` Tony Luck
2012-05-25 16:26       ` Tony Luck
2012-05-29  0:19     ` Anton Blanchard [this message]
2012-06-05  7:16     ` Alex Shi
2012-06-06  7:43 ` Alex Shi
2012-06-06  9:15   ` Peter Zijlstra
2012-06-07  0:34     ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120529101937.70ef0bf1@kryten \
    --to=anton@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=cmetcalf@tilera.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=greg.pearson@hp.com \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rth@twiddle.net \
    --cc=shangw@linux.vnet.ibm.com \
    --cc=sivanich@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.