Re: Booting mx25 based device from SD and NOR

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roberto Nibali <rnibali@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: Booting mx25 based device from SD and NOR
Date: Wed, 30 May 2012 07:47:38 +0200	[thread overview]
Message-ID: <20120530054738.GF30400@pengutronix.de> (raw)
In-Reply-To: <CAONxwYO8Y9uYCr7VeGq9YbybRAGOZFZEQiKOTRfzm-=fH-0ihg@mail.gmail.com>

On Tue, May 29, 2012 at 12:14:52PM +0200, Roberto Nibali wrote:
> ADDENDUM:
> 
> 
> diff --git a/arch/arm/boards/fq-sid1-mx25-noah/Makefile
> b/arch/arm/boards/fq-sid1-mx25-noah/Makefile
> new file mode 100644
> index 0000000..1e9cd54
> --- /dev/null
> +++ b/arch/arm/boards/fq-sid1-mx25-noah/Makefile
> @@ -0,0 +1,26 @@
> +#
> +# (C) Copyright 2007 Juergen Beisert <jbe@pengutronix.de>

You should replace this with your own copyright. I think Jürgen can live
with not having a copyright on trivial files ;)

> diff --git a/arch/arm/boards/fq-sid1-mx25-noah/env/config

Have you considered using one of the environment templates? You
shouldn't duplicate them.

> b/arch/arm/boards/fq-sid1-mx25-noah/env/config
> new file mode 100644
> index 0000000..240056d
> --- /dev/null
> +++ b/arch/arm/boards/fq-sid1-mx25-noah/env/config
> @@ -0,0 +1,25 @@
> +#!/bin/sh
> +
> +autoboot_timeout=5
> +
> +# can be either 'nfs', 'tftp', 'nor', or 'mmc'
> +kernel=tftp
> +root=mmc
> +
> +version=/v2.1.8-rc
> +tftp_uimage=$version/uImage
> +tftp_jffs2=$version/console-image.jffs2
> +bootargs="console=ttymxc0,115200"
> +nfsroot="/home/develop/SID1/nfsroot"
> +nor_parts="512k(barebox)ro,512k(bareboxenv),3072k(kernel),-(root)"
> +nor_rootpart="/dev/mtdblock3"
> +mmc_kernel="/dev/mmcblk0p1"
> +mmc_rootpart="/dev/mmcblk0p2"
> +getip=dhcp
> +
> +# or set your networking parameters here
> +#eth0.ipaddr=192.168.1.80
> +#eth0.netmask=255.255.255.0
> +#eth0.gateway=a.b.c.d
> +eth0.serverip=192.168.1.23
> +eth0.ethaddr=00:50:c2:8c:e6:0e

*never* *ever* add MAC addresses to the default environment.

> +
> diff --git a/arch/arm/boards/fq-sid1-mx25-noah/flash_header.c
> b/arch/arm/boards/fq-sid1-mx25-noah/flash_header.c
> new file mode 100644
> index 0000000..982fc52
> --- /dev/null
> +++ b/arch/arm/boards/fq-sid1-mx25-noah/flash_header.c
> @@ -0,0 +1,88 @@
> +#include <common.h>
> +#include <mach/imx-flash-header.h>
> +#include <mach/imx-regs.h>
> +#include <asm/barebox-arm-head.h>
> +
> +extern void exception_vectors(void);
> +
> +void __naked __flash_header_start go(void)
> +{
> + barebox_arm_head();
> +}
> +
> + DEST_BASE = IMX_CS0_BASE
> +   #else
> + DEST_BASE = TEXT_BASE
> +   #endif
> +   FLASH_HEADER_BASE = (DEST_BASE + FLASH_HEADER_OFFSET)
> + */
> +
> +struct imx_dcd_entry __dcd_entry_section dcd_entry[] = {
> + /* NOR flash, CS0_CSCRU, CS0_CSCRL, CS0_CSCRA */
> + { .ptr_type = 4, .addr = 0xB8002000, .val = 0x0000D003, },
> + { .ptr_type = 4, .addr = 0xB8002004, .val = 0x00330D01, },
> + { .ptr_type = 4, .addr = 0xB8002008, .val = 0x00220800, },
> + /* DDR2 init */
> + { .ptr_type = 4, .addr = 0xb8001004, .val = 0x0076e83a, }, /* initial
> value for ESDCFG0 */

Your mailer wraps lines.

> +#endif
> +#ifdef CONFIG_DRIVER_VIDEO_IMX
> + //imx25_add_fb(&noah_fb_data);

Please remove dead code before posting this for inclusion

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox