From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer Date: Wed, 30 May 2012 12:25:44 +0200 Message-ID: <20120530102544.GC6888@phenom.ffwll.local> References: <1338332468-24483-1-git-send-email-laurent.pinchart@ideasonboard.com> <6315567.0lP5TunKB7@avalon> <20120530100219.GB6888@phenom.ffwll.local> <1703102.0lgQICzOc1@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 637399E77E for ; Wed, 30 May 2012 03:24:19 -0700 (PDT) Received: by eekd17 with SMTP id d17so1937908eek.36 for ; Wed, 30 May 2012 03:24:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1703102.0lgQICzOc1@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, May 30, 2012 at 12:11:49PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: > > On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: > > > On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: > > > > On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: > > > > > The passed mode must not be modified by the operation, make it const. > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > > Acked-by: Daniel Vetter > > > > > > Thank you for the ack. Would you also be so kind as to tell me how to fix > > > the related i915 issue (as briefly stated in the patch, the i915 driver > > > modifies mode->clock in intel_dp_mode_fixup()) ? Or, even better, provide > > > a patch for that ? :-) > > > > Oops, lack of coffee. Patch is in the works. > > No worries :-) As my patch should go on top of yours, could you please take it > in your tree ? Well I think that patch should go through Dave's tree directly. But I send him regular -next pull requests, so that should stall your patch for long. -Daniel > > Btw, do you plan to constify other stuff? > > Not immediately. When I tried to implement .mode_fixup() I wasn't sure whether > drivers were allowed to modify the mode argument. After researching it I came > up to the conclusion that they should not, hence the patch. It would make > sense to constify other structures and function arguments as well though. > > -- > Regards, > > Laurent Pinchart > -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48