From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: assert that the IBX port
 transcoder select w/a is implemented
Date: Wed, 30 May 2012 13:30:28 +0200
Message-ID: <20120530113028.GD6888@phenom.ffwll.local>
References: <1338373918-1532-1-git-send-email-daniel.vetter@ffwll.ch>
	<1338373918-1532-3-git-send-email-daniel.vetter@ffwll.ch>
	<1338373698_354449@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id A10099E771
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 30 May 2012 04:29:03 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so2767909wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 30 May 2012 04:29:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1338373698_354449@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, May 30, 2012 at 11:27:46AM +0100, Chris Wilson wrote:
> On Wed, 30 May 2012 12:31:58 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Let's be a bit more paranoid here.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 3c71850..a9bc673 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -1224,6 +1224,9 @@ static void assert_pch_dp_disabled(struct drm_i915_private *dev_priv,
> >  	WARN(dp_pipe_enabled(dev_priv, pipe, port_sel, val),
> >  	     "PCH DP (0x%08x) enabled on transcoder %c, should be disabled\n",
> >  	     reg, pipe_name(pipe));
> > +
> > +	WARN(HAS_PCH_IBX(dev_priv->dev) && (val & SDVO_PIPE_B_SELECT),
> > +	     "IBX PCH dp port still using transcoder B\n");
> 
> Only an issue if both pipe B selected and enabled, right?

The problem is actually when it's disabled, but still selects transcoder
B. The complicating issue is that we can only change the transcoder while
the port is enabled.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48