From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 3/4] drm: Add NV24 and NV42 pixel formats
Date: Wed, 30 May 2012 16:09:25 +0300
Message-ID: <20120530130925.GR13065@intel.com>
References: <1338381179-13290-1-git-send-email-laurent.pinchart@ideasonboard.com>
	<1338381179-13290-4-git-send-email-laurent.pinchart@ideasonboard.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id D852F9E954
	for <dri-devel@lists.freedesktop.org>;
	Wed, 30 May 2012 06:09:48 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1338381179-13290-4-git-send-email-laurent.pinchart@ideasonboard.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, May 30, 2012 at 02:32:58PM +0200, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  include/drm/drm_fourcc.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> =

> diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
> index bdf0152..fac7235 100644
> --- a/include/drm/drm_fourcc.h
> +++ b/include/drm/drm_fourcc.h
> @@ -106,6 +106,8 @@
>  #define DRM_FORMAT_NV21		fourcc_code('N', 'V', '2', '1') /* 2x2 subsampl=
ed Cb:Cr plane */
>  #define DRM_FORMAT_NV16		fourcc_code('N', 'V', '1', '6') /* 2x1 subsampl=
ed Cr:Cb plane */
>  #define DRM_FORMAT_NV61		fourcc_code('N', 'V', '6', '1') /* 2x1 subsampl=
ed Cb:Cr plane */
> +#define DRM_FORMAT_NV24		fourcc_code('N', 'V', '2', '4') /* non-subsampl=
ed Cr:Cb plane */
> +#define DRM_FORMAT_NV42		fourcc_code('N', 'V', '4', '2') /* non-subsampl=
ed Cb:Cr plane */

If you want these to reach the driver you need to add them to
format_check().

Also you should update drm_format_num_planes() and
drm_format_plane_cpp() appropriately.

-- =

Ville Syrj=E4l=E4
Intel OTC