All of lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] MFD: mc13xxx workaround SPI hardware bug on i.Mx
Date: Wed, 30 May 2012 18:08:38 +0100	[thread overview]
Message-ID: <20120530170837.GR9947@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1338282389-26177-3-git-send-email-philippe.retornaz@epfl.ch>

On Tue, May 29, 2012 at 11:06:29AM +0200, Philippe R?tornaz wrote:
> The MC13xxx PMIC is mainly used on i.Mx SoC. On thoses SoC the SPI
> hardware will deassert CS line as soon as the SPI FIFO is empty.
> The MC13xxx hardware is very sensitive to CS line change as it
> corrupts the transfert if CS is deasserted in the middle of a register
> read or write.
> It is not possible to use the CS line as a GPIO on some SoC, so we
> need to workaround this by implementing a single SPI transfer to
> access the PMIC.

Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

though it's really sad this can't be done in the SPI controller where
the bug is.  You should also set use_single_rw in the regmap_config,
though this is less critical as currently the core won't automatically
generate any bulk I/O.

Obviously this will affect a much wider range of devices when used with
i.MX.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120530/0b925a82/attachment.sig>

       reply	other threads:[~2012-05-30 17:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1338282389-26177-1-git-send-email-philippe.retornaz@epfl.ch>
     [not found] ` <1338282389-26177-2-git-send-email-philippe.retornaz@epfl.ch>
     [not found]   ` <1338282389-26177-3-git-send-email-philippe.retornaz@epfl.ch>
2012-05-30 17:08     ` Mark Brown [this message]
2012-05-31  7:08       ` [PATCH 2/2] MFD: mc13xxx workaround SPI hardware bug on i.Mx Philippe Rétornaz
2012-05-31  9:03         ` Samuel Ortiz
2012-06-22 15:48           ` Fabio Estevam
2012-06-29  7:41             ` Philippe Rétornaz
2012-05-31 13:57         ` Mark Brown
2012-05-30 23:47     ` Marc Reilly
2012-05-31 23:51   ` [PATCH 1/2] MFD: Fix mc13xxx SPI regmap Fabio Estevam
2012-06-29 13:09 ` [PATCH 0/2] MC13xxx: fix access on i.mx31 Samuel Ortiz
2012-07-01 11:03   ` Philippe Rétornaz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120530170837.GR9947@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.