From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <sjhill@mips.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 0/5] Add explicit support YAMON firmware.
Date: Thu, 31 May 2012 09:29:44 +0100 [thread overview]
Message-ID: <20120531082944.GL30086@linux-mips.org> (raw)
In-Reply-To: <1338415855-11401-1-git-send-email-sjhill@mips.com>
On Wed, May 30, 2012 at 05:10:50PM -0500, Steven J. Hill wrote:
Now for the nitpicking :-)
ar7_defconfig breaks with:
CC arch/mips/ar7/memory.o
/home/ralf/src/linux/upstream-sfr/arch/mips/ar7/memory.c:33:34: fatal error: asm/mips-boards/prom.h: No such file or directory
compilation terminated.
make[4]: *** [arch/mips/ar7/memory.o] Error 1
db1000_defconfig, db1200_defconfig, db1300_defconfig and db1550_defconfig
breaks with:
CC arch/mips/alchemy/common/prom.o
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c: In function ‘prom_get_ethernet_addr’:
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c:73:2: error: implicit declaration of function ‘prom_getenv’ [-Werror=implicit-function-declaration]
/home/ralf/src/linux/upstream-sfr/arch/mips/alchemy/common/prom.c:73:14: error: assignment makes pointer from integer without a cast [-Werror]
cc1: all warnings being treated as errors
make[4]: *** [arch/mips/alchemy/common/prom.o] Error 1
Test build still running - ENEEDMOREHORSEPOWER ;-) So far
bcm63xx_defconfig, capcella_defconfig and cavium-octeon_defconfig build ok.
> arch/mips/include/asm/mipsprom.h | 2 -
This is the firmware used by the systems built by MIPS Computer Systems Inc.
and a few very old SGI pre-ARC(S) systems, also some by Pyramid,
Siemens-Nixdorf and others. It has nothing to do with YAMON.
> .../mips/include/asm/pmc-sierra/msp71xx/msp_prom.h | 26 -------
> arch/mips/pmc-sierra/msp71xx/msp_prom.c | 76 +-----------------
> arch/mips/pmc-sierra/msp71xx/msp_setup.c | 2 +-
And these use PMON 2000. That you found possibilities to share code
beyond YAMON's realm is good but infecting non-YAMON platforms with
YAMON headers isn't. I suggest to gather code that can kind of code
in arch/mips/lib or a new directory arch/mips/fw/lib.
Ralf
prev parent reply other threads:[~2012-05-31 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 22:10 [PATCH 0/5] Add explicit support YAMON firmware Steven J. Hill
2012-05-30 22:10 ` [PATCH 1/5] MIPS: Add initial support for " Steven J. Hill
2012-05-30 22:10 ` [PATCH 2/5] MIPS: Clean up YAMON support for Alchemy platforms Steven J. Hill
2012-05-30 22:10 ` [PATCH 3/5] MIPS: Clean up YAMON support for PowerTV platform Steven J. Hill
2012-05-30 22:10 ` [PATCH 4/5] MIPS: Clean up YAMON support for PMC Sierra platforms Steven J. Hill
2012-05-30 22:10 ` [PATCH 5/5] MIPS: Clean up YAMON support for MIPS Malta and SEAD-3 platforms Steven J. Hill
2012-05-30 23:47 ` [PATCH 0/5] Add explicit support YAMON firmware Ralf Baechle
2012-05-30 23:50 ` Maciej W. Rozycki
2012-05-31 8:29 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531082944.GL30086@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.