From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Adam Thomson <Adam.Thomson@diasemi.com>
Cc: alsa-devel@alsa-project.org, Michal Hajduk <Michal.Hajduk@diasemi.com>
Subject: Re: [PATCH 1/2] ASoC: core: Add single controls with specified range of values
Date: Thu, 31 May 2012 13:07:39 +0100 [thread overview]
Message-ID: <20120531120738.GC2666@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201205311027.q4VARIG5009001@sw-eng-lt-apt-vm1>
[-- Attachment #1.1: Type: text/plain, Size: 564 bytes --]
On Thu, May 31, 2012 at 11:19:15AM +0100, Adam Thomson wrote:
> +#define SOC_SINGLE_RANGE_TLV(xname, xreg, xshift, xmin, xmax, tlv_array) \
> +{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = (xname),\
> + .access = SNDRV_CTL_ELEM_ACCESS_TLV_READ |\
> + SNDRV_CTL_ELEM_ACCESS_READWRITE,\
This looks good but please also add an invert flag to this so we can
cope if the device does that, it's easier than having more macros to
choose from.
It'd be good to have a non-TLV version too, should just be a case of
adding a new macro (even if it's not normally used).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-05-31 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 10:19 [PATCH 1/2] ASoC: core: Add single controls with specified range of values Adam Thomson
2012-05-31 12:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531120738.GC2666@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Adam.Thomson@diasemi.com \
--cc=Michal.Hajduk@diasemi.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.