From: Andrew Morton <akpm@linux-foundation.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: hughd@google.com, npiggin@gmail.com, cl@linux.com,
lee.schermerhorn@hp.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, stable@vger.kernel.org, riel@redhat.com
Subject: Re: [PATCH v2] tmpfs not interleaving properly
Date: Thu, 31 May 2012 12:28:29 -0700 [thread overview]
Message-ID: <20120531122829.8c478372.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120531143916.GA16162@gulag1.americas.sgi.com>
On Thu, 31 May 2012 09:39:17 -0500
Nathan Zimmer <nzimmer@sgi.com> wrote:
> When tmpfs has the memory policy interleaved it always starts allocating at each
> file at node 0. When there are many small files the lower nodes fill up
> disproportionately.
> This patch attempts to spread out node usage by starting files at nodes other
> then 0. I disturbed the addr parameter since alloc_pages_vma will only use it
> when the policy is MPOL_INTERLEAVE. Random was picked over using another
> variable which would require some sort of contention management.
The patch title is a bit scummy ;) It describes a kernel problem, not
the patch. I renamed it to "tmpfs: implement NUMA node interleaving".
It looks nice and simple
> Cc: stable@vger.kernel.org
We could probably sneak this past Greg, but should we? It's a feature
and a performance enhancement. Such things are not normally added to
-stable. If there were some nice performance improvements in workloads
which our users care about then I guess we could backport it.
But you've provided us with no measurements at all, hence no reason to
backport it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: hughd@google.com, npiggin@gmail.com, cl@linux.com,
lee.schermerhorn@hp.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, stable@vger.kernel.org, riel@redhat.com
Subject: Re: [PATCH v2] tmpfs not interleaving properly
Date: Thu, 31 May 2012 12:28:29 -0700 [thread overview]
Message-ID: <20120531122829.8c478372.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120531143916.GA16162@gulag1.americas.sgi.com>
On Thu, 31 May 2012 09:39:17 -0500
Nathan Zimmer <nzimmer@sgi.com> wrote:
> When tmpfs has the memory policy interleaved it always starts allocating at each
> file at node 0. When there are many small files the lower nodes fill up
> disproportionately.
> This patch attempts to spread out node usage by starting files at nodes other
> then 0. I disturbed the addr parameter since alloc_pages_vma will only use it
> when the policy is MPOL_INTERLEAVE. Random was picked over using another
> variable which would require some sort of contention management.
The patch title is a bit scummy ;) It describes a kernel problem, not
the patch. I renamed it to "tmpfs: implement NUMA node interleaving".
It looks nice and simple
> Cc: stable@vger.kernel.org
We could probably sneak this past Greg, but should we? It's a feature
and a performance enhancement. Such things are not normally added to
-stable. If there were some nice performance improvements in workloads
which our users care about then I guess we could backport it.
But you've provided us with no measurements at all, hence no reason to
backport it.
next prev parent reply other threads:[~2012-05-31 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 14:39 [PATCH v2] tmpfs not interleaving properly Nathan Zimmer
2012-05-31 14:39 ` Nathan Zimmer
2012-05-31 19:28 ` Andrew Morton [this message]
2012-05-31 19:28 ` Andrew Morton
2012-05-31 20:09 ` KOSAKI Motohiro
2012-05-31 20:09 ` KOSAKI Motohiro
2012-05-31 20:25 ` Andrew Morton
2012-05-31 20:25 ` Andrew Morton
2012-05-31 20:35 ` KOSAKI Motohiro
2012-05-31 20:35 ` KOSAKI Motohiro
2012-06-01 14:24 ` Nathan Zimmer
2012-06-01 14:24 ` Nathan Zimmer
2012-06-01 17:22 ` KOSAKI Motohiro
2012-06-01 17:22 ` KOSAKI Motohiro
2012-06-19 23:21 ` Nathan Zimmer
2012-06-19 23:21 ` Nathan Zimmer
2012-06-20 4:02 ` KOSAKI Motohiro
2012-06-20 4:02 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531122829.8c478372.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=nzimmer@sgi.com \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.