From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] bootcount: Move bootcount.c from arch/powerpc/lib to lib
Date: Thu, 31 May 2012 13:23:02 +0200 [thread overview]
Message-ID: <201205311323.02153.sr@denx.de> (raw)
In-Reply-To: <4FC74B04.4070409@denx.de>
Hi Heiko,
On Thursday 31 May 2012 12:42:12 Heiko Schocher wrote:
> > diff --git a/arch/powerpc/lib/bootcount.c b/lib/bootcount.c
> > similarity index 100%
> > rename from arch/powerpc/lib/bootcount.c
> > rename to lib/bootcount.c
>
> If we do this, we should try to move all bootcounter implementations
> to this file, see:
>
> [hs at pollux u-boot]$ grep -lr bootcount_store .
> ./common/main.c
> ./arch/powerpc/lib/bootcount.c
> ./arch/arm/cpu/arm926ejs/at91/cpu.c
> ./arch/arm/cpu/armv7/highbank/bootcount.c
> ./arch/arm/cpu/ixp/cpu.c
> ./arch/blackfin/cpu/bootcount.c
> ./board/enbw/enbw_cmc/enbw_cmc.c
> ./board/omicron/calimain/calimain.c
> ./board/keymile/km_arm/km_arm.c
> ./include/common.h
> [hs at pollux u-boot]$
>
> and should provide a possibility to add board specific code,
> for example needed for the
>
> board/keymile/km_arm/km_arm.c boards.
>
> Have you done a "MAKEALL arm"? I think (didn;t tried it) this
> would fail with your patch ...
No. You're right. It fails for some boards. I'll try to come up with a more
generic solution to enable those board specific implementations.
Thanks,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
prev parent reply other threads:[~2012-05-31 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 8:58 [U-Boot] [PATCH] bootcount: Move bootcount.c from arch/powerpc/lib to lib Stefan Roese
2012-05-31 10:42 ` Heiko Schocher
2012-05-31 11:23 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205311323.02153.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.