All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Anthony Olech <Anthony.Olech@diasemi.com>
Subject: Re: [PATCH 4/4] regmap: Minor optimisation for _regmap_raw_write().
Date: Thu, 31 May 2012 17:44:19 +0100	[thread overview]
Message-ID: <20120531164419.GL2666@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201205311622.q4VGMHGe015484@sw-eng-lt-dc-vm2>

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Thu, May 31, 2012 at 05:11:38PM +0200, Krystian Garbaciak wrote:
> Just to make things simplier inside the function.

Again, what is this actually doing (ie, please improve your changelogs)?

It looks like it's just factoring constants out (which hopefully the
compiler can do but still is OK) - this looks good but should probably
be at the start rather than end of the series.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-05-31 16:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-31 15:11 [PATCH 4/4] regmap: Minor optimisation for _regmap_raw_write() Krystian Garbaciak
2012-05-31 16:44 ` Mark Brown [this message]
2012-05-31 17:57   ` Krystian Garbaciak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120531164419.GL2666@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=Anthony.Olech@diasemi.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krystian.garbaciak@diasemi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.