From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page
Date: Thu, 31 May 2012 22:28:10 +0530 [thread overview]
Message-ID: <20120531165810.GE24279@linux.vnet.ibm.com> (raw)
In-Reply-To: <1338483372.28384.65.camel@twins>
* Peter Zijlstra <peterz@infradead.org> [2012-05-31 18:56:12]:
> On Thu, 2012-05-31 at 20:37 +0530, Srikar Dronamraju wrote:
> > * Peter Zijlstra <peterz@infradead.org> [2012-05-31 13:58:38]:
> >
> > > On Thu, 2012-05-31 at 17:16 +0530, Srikar Dronamraju wrote:
> > > > From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > > >
> > > > No need to lock the page when copying the opcode in read_opcode().
> > >
> > > It would be good if the changelog said _why_ this is so :-)
> >
> > In read_opcode(), we have the reference for the page and we only are reading
> > from the the page. i.e we are neither modifying the page contents, not
> > the page attributes.
>
> Fair enough, so put that in the changelog. The changelog should explain
> things, not raise questions.
>
Okay, will add this info to the Changelog and resend the patch.
--
Thanks and Regards
Srikar
next prev parent reply other threads:[~2012-05-31 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 11:46 [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Srikar Dronamraju
2012-05-31 11:46 ` [PATCH 2/3] perf/uprobes: Remove unnecessary check before strlist__delete Srikar Dronamraju
2012-06-06 7:08 ` [tip:perf/urgent] perf uprobes: " tip-bot for Srikar Dronamraju
2012-05-31 11:46 ` [PATCH 3/3] perf: Check for valid dso before creating map Srikar Dronamraju
2012-06-06 7:07 ` [tip:perf/urgent] perf symbols: " tip-bot for Srikar Dronamraju
2012-05-31 11:58 ` [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page Peter Zijlstra
2012-05-31 14:22 ` Steven Rostedt
2012-05-31 15:07 ` Srikar Dronamraju
2012-05-31 16:56 ` Peter Zijlstra
2012-05-31 16:58 ` Srikar Dronamraju [this message]
2012-06-01 9:19 ` [RESEND PATCH 1/3] uprobes: " Srikar Dronamraju
2012-06-01 18:52 ` Oleg Nesterov
2012-06-06 9:18 ` Ingo Molnar
2012-06-06 9:19 ` Peter Zijlstra
2012-08-06 11:57 ` Anton Arapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531165810.GE24279@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=acme@infradead.org \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.