From: Al Viro <viro@ZenIV.linux.org.uk>
To: majianpeng <majianpeng@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Re: [PATCH] export kernel call set_task_comm()
Date: Fri, 1 Jun 2012 02:24:45 +0100 [thread overview]
Message-ID: <20120601012445.GF30000@ZenIV.linux.org.uk> (raw)
In-Reply-To: <201206010911269377891@gmail.com>
On Fri, Jun 01, 2012 at 09:11:32AM +0800, majianpeng wrote:
> On Thu, 31 May 2012 17:00:54 +0100 , viro wrote:
> >On Thu, May 31, 2012 at 03:16:18PM +0800, majianpeng wrote:
> >> In Commit 7d74f492e4dd0034a61458eb80f70b1d2862ed07,author said:
> >> "This allows drivers who call this function to be compiled modularly.
> >> Otherwise, a driver who is interested in this type of functionality
> >> has to implement their own get_task_comm() call, causing code
> >> duplication in the Linux source tree."
> >>
> >> But author did not say about set_task_comm().At present,I used it but
> >> compiled error.To the same purpose, it should export.
>
> >Are you doing that to preexisting process? Or just to a kernel thread
> >you are creating? In the latter case, you really ought to use
> >kthread_create() instead of bare-metal kernel_thread()...
>
> Yes, I am doing that to preexisting process and in module.So I think it should export.
Why is that module playing with ->comm[] of process it hadn't spawned?
Note that _reading_ ->comm[] has fairly mundane uses - debugging printks
and all such. Changing it, OTOH...
Details, please; "my module calls that, so it should be exported" is not enough.
next prev parent reply other threads:[~2012-06-01 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 7:16 [PATCH] export kernel call set_task_comm() majianpeng
2012-05-31 16:00 ` Al Viro
2012-06-01 1:15 ` majianpeng
[not found] ` <201206010911269377891@gmail.com>
2012-06-01 1:24 ` Al Viro [this message]
2012-06-01 2:13 ` majianpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601012445.GF30000@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.