From: Ted Ts'o <tytso@mit.edu>
To: Salman Qazi <sqazi@google.com>
Cc: Ted Ts'o <tytso@google.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: remove mb_groups before tearing buddy_cache
Date: Fri, 1 Jun 2012 00:09:33 -0400 [thread overview]
Message-ID: <20120601040933.GE7897@thunk.org> (raw)
In-Reply-To: <20120529233614.12259.28652.stgit@dungbeetle.mtv.corp.google.com>
On Tue, May 29, 2012 at 04:36:14PM -0700, Salman Qazi wrote:
> We can't have references held on pages in the s_buddy_cache while we are
> trying to truncate its pages and put the inode. All the pages must be
> gone before we reach clear_inode. This can only be gauranteed if we
> can prevent new users from grabbing references to s_buddy_cache's pages.
>
> The original bug can be reproduced and the bug fix can be verified by:
>
> while true; do mount -t ext4 /dev/ram0 /export/hda3/ram0; \
> umount /export/hda3/ram0; done &
>
> while true; do cat /proc/fs/ext4/ram0/mb_groups; done
>
> Signed-off-by: Salman Qazi <sqazi@google.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2012-06-01 4:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 23:36 [PATCH 0/2] ext4: Fix some crashes on umount Salman Qazi
2012-05-29 23:36 ` [PATCH 1/2] ext4: Add ext4_mb_unload_buddy in the error path Salman Qazi
2012-06-01 4:09 ` Ted Ts'o
2012-05-29 23:36 ` [PATCH 2/2] ext4: remove mb_groups before tearing buddy_cache Salman Qazi
2012-06-01 4:09 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601040933.GE7897@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sqazi@google.com \
--cc=tytso@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.