From: Josef Bacik <josef@redhat.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Josef Bacik <josef@redhat.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: Update mtab if necessary when device was deleted in btrfs
Date: Fri, 1 Jun 2012 08:46:49 -0400 [thread overview]
Message-ID: <20120601124648.GC2652@localhost.localdomain> (raw)
In-Reply-To: <4FC81DDA.70004@cn.fujitsu.com>
On Fri, Jun 01, 2012 at 09:41:46AM +0800, Miao Xie wrote:
> On Thu, 31 May 2012 10:31:48 -0400, Josef Bacik wrote:
> > On Thu, May 31, 2012 at 06:28:31PM +0800, Miao Xie wrote:
> >> Now if we remove the device that is specified when mounting, btrfs will update
> >> the mount information in /proc, such as the information in /proc/mounts. So
> >> in order to guarantee the consistency between /etc/mtab and the mount
> >> information in /proc, we must update /etc/mtab. This patch does it.
> >>
> >> This patch need libmount and libmount-devel(version >= 2.19) packages to
> >> compile.
> >>
> >
> > Does this work well with say Fedora where /etc/mtab is just a symlink to
> > /proc/mounts? Thanks,
>
> Yes, if /etc/mtab is not a regular file, we will skip the update. And I have
> do some test for it and all of them passed.
>
> This patch can not work well on your machine?
>
It didn't but I think I screwed something up so ignore me. Thanks,
Josef
prev parent reply other threads:[~2012-06-01 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 10:28 [PATCH] Btrfs-progs: Update mtab if necessary when device was deleted in btrfs Miao Xie
2012-05-31 14:31 ` Josef Bacik
2012-06-01 1:41 ` Miao Xie
2012-06-01 12:46 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601124648.GC2652@localhost.localdomain \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.