From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq
Date: Fri, 1 Jun 2012 16:28:35 +0300 [thread overview]
Message-ID: <20120601132834.GB21451@redhat.com> (raw)
In-Reply-To: <4FC8BB28.8000004@siemens.com>
On Fri, Jun 01, 2012 at 02:52:56PM +0200, Jan Kiszka wrote:
> On 2012-05-30 22:31, Michael S. Tsirkin wrote:
> >>> So we'll just have PIIX_NUM_PIC_IRQS entries there and use
> >>> irq_count instead of the pic_levels bitmap.
> >>
> >> Just that this affects generic PCI code, not only PIIX-specific things.
> >
> > Yes but it's not a problem - pci_bus_irqs sets the map function and nirqs.
> >
> >> And that we need to save/restore some irq_count field according to the
> >> old semantics.
> >
> > Well, it's a bug: this is redundant info we should not have exposed it.
> >
> > Anyway, let's make the rest work properly and cleanly first, add a FIXME
> > for now, then we'll find a hack making it work for migration.
>
> It remains non-trivial: I got your patch working (a minor init issue),
> but yet without changing the number of IRQs for PIIX3, so keeping the
> irq_count semantics for this host bridge.
BTW can you post the fixed version please in case
others want to play with it?
next prev parent reply other threads:[~2012-06-01 13:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4FC65910.4030908@siemens.com>
[not found] ` <20120530174125.GC32721@redhat.com>
[not found] ` <4FC65E19.6090203@siemens.com>
[not found] ` <4FC65F70.4040501@siemens.com>
[not found] ` <20120530182356.GD32721@redhat.com>
[not found] ` <20120530182913.GE32721@redhat.com>
[not found] ` <20120530185150.GA1546@redhat.com>
[not found] ` <4FC66FB1.9050306@siemens.com>
[not found] ` <20120530193034.GE1551@redhat.com>
[not found] ` <4FC681B4.3030807@web.de>
[not found] ` <20120530203119.GH1551@redhat.com>
2012-06-01 12:52 ` [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq Jan Kiszka
2012-06-01 13:27 ` Michael S. Tsirkin
2012-06-01 13:57 ` Jan Kiszka
2012-06-01 14:34 ` Michael S. Tsirkin
2012-06-01 15:15 ` Jan Kiszka
2012-06-01 15:28 ` Michael S. Tsirkin
2012-06-01 15:54 ` Jan Kiszka
2012-06-01 16:05 ` Michael S. Tsirkin
2012-06-01 16:17 ` Jan Kiszka
2012-06-01 15:30 ` Michael S. Tsirkin
2012-06-01 15:59 ` Jan Kiszka
2012-06-01 15:26 ` Michael S. Tsirkin
2012-06-01 13:28 ` Michael S. Tsirkin [this message]
2012-06-01 13:43 ` Jan Kiszka
2012-05-21 13:13 Jan Kiszka
2012-05-21 14:10 ` Alex Williamson
2012-05-21 14:36 ` Avi Kivity
2012-05-21 14:47 ` Jan Kiszka
2012-05-21 17:34 ` Michael S. Tsirkin
2012-05-21 18:58 ` Jan Kiszka
2012-05-21 21:04 ` Michael S. Tsirkin
2012-05-21 19:05 ` Michael S. Tsirkin
2012-05-21 20:35 ` Jan Kiszka
2012-05-21 21:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601132834.GB21451@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.