All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Kuo <rkuo@codeaurora.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-hexagon@vger.kernel.org
Subject: Re: [PATCH 17/20] hexagon: Do not call try_to_freeze() in do_signal()
Date: Fri, 1 Jun 2012 14:02:21 -0500	[thread overview]
Message-ID: <20120601190221.GE23541@codeaurora.org> (raw)
In-Reply-To: <1337983476-22081-17-git-send-email-richard@nod.at>

On Sat, May 26, 2012 at 12:04:33AM +0200, Richard Weinberger wrote:
> get_signal_to_deliver() already calls try_to_freeze(), there is no
> need to call it directly.
> 
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  arch/hexagon/kernel/signal.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/hexagon/kernel/signal.c b/arch/hexagon/kernel/signal.c
> index 8403bfd..9783cfa 100644
> --- a/arch/hexagon/kernel/signal.c
> +++ b/arch/hexagon/kernel/signal.c
> @@ -20,7 +20,6 @@
>  
>  #include <linux/linkage.h>
>  #include <linux/syscalls.h>
> -#include <linux/freezer.h>
>  #include <linux/tracehook.h>
>  #include <linux/irqflags.h>
>  #include <asm/registers.h>
> @@ -210,9 +209,6 @@ static void do_signal(struct pt_regs *regs)
>  	if (!user_mode(regs))
>  		return;
>  
> -	if (try_to_freeze())
> -		goto no_signal;
> -
>  	signo = get_signal_to_deliver(&info, &sigact, regs, NULL);
>  
>  	if (signo > 0) {
> @@ -237,7 +233,6 @@ static void do_signal(struct pt_regs *regs)
>  		return;
>  	}
>  
> -no_signal:
>  	/*
>  	 * If we came from a system call, handle the restart.
>  	 */
> -- 
> 1.7.7.3
> 

Acked-by: Richard Kuo <rkuo@codeaurora.org>

-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  parent reply	other threads:[~2012-06-01 19:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 22:04 [PATCH 01/20] arm: Do not call do_signal() with irqs disabled Richard Weinberger
2012-05-25 22:04 ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 02/20] c6x: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 03/20] cris: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 04/20] h8300: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 05/20] hexagon: " Richard Weinberger
2012-06-01 17:54   ` Richard Kuo
2012-06-01 18:42     ` David Brown
2012-06-01 19:01       ` Richard Kuo
2012-06-01 19:02   ` Richard Kuo
2012-05-25 22:04 ` [PATCH 06/20] m32r: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 07/20] mn10300: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 08/20] openrisc: " Richard Weinberger
2012-05-25 22:04   ` Richard Weinberger
2012-05-25 22:04   ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 09/20] score: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 10/20] sh: " Richard Weinberger
2012-05-25 22:04   ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 11/20] tile: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 12/20] unicore32: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 13/20] arm: Do not call try_to_freeze() in do_signal() Richard Weinberger
2012-05-25 22:04   ` Richard Weinberger
2012-05-25 23:43   ` Russell King - ARM Linux
2012-05-25 23:43     ` Russell King - ARM Linux
2012-05-26  8:55     ` Richard Weinberger
2012-05-26  8:55       ` Richard Weinberger
     [not found] ` <1337983476-22081-1-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
2012-05-25 22:04   ` [PATCH 14/20] blackfin: " Richard Weinberger
2012-05-25 22:04     ` Richard Weinberger
2012-05-25 22:04 ` [PATCH 15/20] frv: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 16/20] h8300: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 17/20] hexagon: " Richard Weinberger
2012-06-01 17:55   ` Richard Kuo
2012-06-01 19:02   ` Richard Kuo [this message]
2012-05-25 22:04 ` [PATCH 18/20] m32r: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 19/20] unicore32: " Richard Weinberger
2012-05-25 22:04 ` [PATCH 20/20] xtensa: " Richard Weinberger
2012-05-25 23:45 ` [PATCH 01/20] arm: Do not call do_signal() with irqs disabled Russell King - ARM Linux
2012-05-25 23:45   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120601190221.GE23541@codeaurora.org \
    --to=rkuo@codeaurora.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.