All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: GIT PULL] ext4 updates for 3.5
Date: Fri, 1 Jun 2012 16:38:36 -0400	[thread overview]
Message-ID: <20120601203836.GB19987@thunk.org> (raw)
In-Reply-To: <7v4nqu3lhy.fsf@alter.siamese.dyndns.org>

One other thought.  One of the reasons why I used "dev" and not
"ext4_for_linus" in my git request-pull command line was because that
several months ago I had created a branch called ext4_for_linus, and I
hadn't gotten around to deleting it, so I figured I'd just use "dev"
instead, since it was non-ambiguous.

If there is a case where there is both tag and a branch with the same
name, it might be a good idea for request-pull not just to issue a
warning, since the user might not notice the warning, but to just
abort --- and make the user explicitly type refs/tags/ext4_for_linus
or refs/heads/ext4_for_linus.

Most of the time if the user ignores the warning about the ambiguity,
it's not such a big deal, but in the case of a pull-request, he or she
is going to be possibly embarassing themself publically, so it might
be better to explicitly list the reason why a non-qualified refname is
ambiguous and force the user to pick the right one.

It's a minor point, and usually I double check the commit id in the
pull request just to be sure, so it might be considered too much of
coddling the user, but it might be a good safety check to add.

						- Ted

  parent reply	other threads:[~2012-06-01 20:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 15:07 GIT PULL] ext4 updates for 3.5 Theodore Ts'o
2012-06-01 15:44 ` Linus Torvalds
2012-06-01 15:44   ` Linus Torvalds
2012-06-01 17:19   ` Linus Torvalds
2012-06-01 17:43     ` Ted Ts'o
2012-06-01 17:56       ` Linus Torvalds
2012-06-01 17:56         ` Linus Torvalds
2012-06-01 18:55         ` Junio C Hamano
2012-06-01 19:00           ` Junio C Hamano
2012-06-01 19:02             ` Linus Torvalds
2012-06-01 20:38             ` Ted Ts'o [this message]
2012-06-01 20:43               ` Linus Torvalds
2012-06-01 20:52                 ` Ted Ts'o
2012-06-01 20:52                 ` Junio C Hamano
2012-06-01 16:45 ` Mark Lord
2012-06-01 17:53   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120601203836.GB19987@thunk.org \
    --to=tytso@mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.