From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] jpeg-turbo: new package
Date: Sun, 3 Jun 2012 09:21:36 +0200 [thread overview]
Message-ID: <20120603092136.3a462ea1@skate> (raw)
In-Reply-To: <CA+pfegELseWchx5hbbChKKi-=xtQMO9CWTyKBEV+6RpRQVEqBA@mail.gmail.com>
Hello,
Le Sun, 3 Jun 2012 05:57:46 +0300,
Murat Demirten <mdemirten@yh.com.tr> a ?crit :
> --- /dev/null
> +++ b/package/jpeg-turbo/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_JPEG_TURBO
> + bool "jpeg-turbo"
Indentation should be one tab.
> + help
Here as well.
> + It is a derivative of libjpeg that uses SIMD instructions
> + (MMX, SSE2, NEON) to accelerate baseline JPEG compression
> + and decompression on x86, x86-64, and ARM systems.
> +
> + http://libjpeg-turbo.virtualgl.org
Indentation should be one tab + two spaces (for the help text)
> +choice
> + prompt "libjpeg api version"
Fix indentation everywhere :)
> --- /dev/null
> +ifeq ($(BR2_PACKAGE_JPEG_TURBO_APIVERSION_62),y)
> + JPEG_TURBO_CONF_ENV += JPEG_LIB_VERSION=62
> +endif
> +
> +$(eval $(call AUTOTARGETS))
> +$(eval $(call AUTOTARGETS,host))
There's no need to have a host variant of this package I think.
Also, your patch is line-wrapped, so it cannot easily be applied. Could
you fix your e-mail client, or better, use git send-email to send your
patch?
Thanks a lot for your contribution!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-06-03 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-03 2:57 [Buildroot] [PATCH] jpeg-turbo: new package Murat Demirten
2012-06-03 7:21 ` Thomas Petazzoni [this message]
2012-06-03 10:12 ` Murat Demirten
2012-06-03 10:53 ` Samuel Martin
2012-06-03 11:17 ` Murat Demirten
2012-06-04 7:51 ` Peter Korsgaard
2012-06-04 8:41 ` Murat Demirten
-- strict thread matches above, loose matches on Subject: below --
2012-06-03 11:04 Murat Demirten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120603092136.3a462ea1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.