From: Shaohua Li <shli@kernel.org>
To: linux-raid@vger.kernel.org
Cc: neilb@suse.de, axboe@kernel.dk, dan.j.williams@intel.com,
shli@fusionio.com
Subject: [patch 5/8] raid5: add batch stripe release
Date: Mon, 04 Jun 2012 16:01:57 +0800 [thread overview]
Message-ID: <20120604080328.104071243@kernel.org> (raw)
In-Reply-To: 20120604080152.098975870@kernel.org
[-- Attachment #1: raid5-stripe-batch.patch --]
[-- Type: text/plain, Size: 2244 bytes --]
Add stripe batch and corresponding batch stripe release. Next patch will use it
to reduce device_lock locking.
Signed-off-by: Shaohua Li <shli@fusionio.com>
---
drivers/md/raid5.c | 35 +++++++++++++++++++++++++++++++++++
drivers/md/raid5.h | 6 ++++++
2 files changed, 41 insertions(+)
Index: linux/drivers/md/raid5.c
===================================================================
--- linux.orig/drivers/md/raid5.c 2012-06-01 14:03:17.062826938 +0800
+++ linux/drivers/md/raid5.c 2012-06-01 14:13:46.846909398 +0800
@@ -262,6 +262,41 @@ static void release_stripe(struct stripe
__release_stripe(conf, sh, 1);
}
+static void __release_stripe_flush_batch(struct stripe_head_batch *batch)
+{
+ int i;
+
+ for (i = 0; i < batch->count; i++) {
+ struct stripe_head *sh = batch->stripes[i];
+ __release_stripe(sh->raid_conf, sh, 0);
+ }
+ batch->count = 0;
+}
+
+static void release_stripe_flush_batch(struct stripe_head_batch *batch)
+{
+ struct r5conf *conf = batch->stripes[0]->raid_conf;
+
+ spin_lock_irq(&conf->device_lock);
+ __release_stripe_flush_batch(batch);
+ spin_unlock_irq(&conf->device_lock);
+}
+
+static void release_stripe_add_batch(struct stripe_head_batch *batch,
+ struct stripe_head *sh)
+{
+ struct r5conf *conf = sh->raid_conf;
+
+ preempt_disable();
+ if (batch->count > 0 && batch->stripes[0]->raid_conf != conf)
+ release_stripe_flush_batch(batch);
+ batch->stripes[batch->count] = sh;
+ batch->count++;
+ if (batch->count >= MAX_STRIPE_BATCH)
+ release_stripe_flush_batch(batch);
+ preempt_enable();
+}
+
static inline void remove_hash(struct stripe_head *sh)
{
pr_debug("remove_hash(), stripe %llu\n",
Index: linux/drivers/md/raid5.h
===================================================================
--- linux.orig/drivers/md/raid5.h 2012-06-01 13:44:19.229127709 +0800
+++ linux/drivers/md/raid5.h 2012-06-01 14:13:46.846909398 +0800
@@ -239,6 +239,12 @@ struct stripe_head {
} dev[1]; /* allocated with extra space depending of RAID geometry */
};
+#define MAX_STRIPE_BATCH 8
+struct stripe_head_batch {
+ struct stripe_head *stripes[MAX_STRIPE_BATCH];
+ int count;
+};
+
/* stripe_head_state - collects and tracks the dynamic state of a stripe_head
* for handle_stripe.
*/
next prev parent reply other threads:[~2012-06-04 8:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 8:01 [patch 0/8] raid5: improve write performance for fast storage Shaohua Li
2012-06-04 8:01 ` [patch 1/8] raid5: add a per-stripe lock Shaohua Li
2012-06-07 0:54 ` NeilBrown
2012-06-07 6:29 ` Shaohua Li
2012-06-07 6:35 ` NeilBrown
2012-06-07 6:52 ` Shaohua Li
2012-06-12 21:02 ` Dan Williams
2012-06-13 4:08 ` Dan Williams
2012-06-13 4:23 ` Shaohua Li
2012-06-12 21:10 ` Dan Williams
2012-06-04 8:01 ` [patch 2/8] raid5: lockless access raid5 overrided bi_phys_segments Shaohua Li
2012-06-07 1:06 ` NeilBrown
2012-06-12 20:41 ` Dan Williams
2012-06-04 8:01 ` [patch 3/8] raid5: remove some device_lock locking places Shaohua Li
2012-06-04 8:01 ` [patch 4/8] raid5: reduce chance release_stripe() taking device_lock Shaohua Li
2012-06-07 0:50 ` NeilBrown
2012-06-04 8:01 ` Shaohua Li [this message]
2012-06-04 8:01 ` [patch 6/8] raid5: make_request use batch stripe release Shaohua Li
2012-06-07 1:23 ` NeilBrown
2012-06-07 6:33 ` Shaohua Li
2012-06-07 7:33 ` NeilBrown
2012-06-07 7:58 ` Shaohua Li
2012-06-08 6:16 ` Shaohua Li
2012-06-08 6:42 ` NeilBrown
2012-06-04 8:01 ` [patch 7/8] raid5: raid5d handle stripe in batch way Shaohua Li
2012-06-07 1:32 ` NeilBrown
2012-06-07 6:35 ` Shaohua Li
2012-06-07 7:38 ` NeilBrown
2012-06-04 8:02 ` [patch 8/8] raid5: create multiple threads to handle stripes Shaohua Li
2012-06-07 1:39 ` NeilBrown
2012-06-07 6:45 ` Shaohua Li
2012-06-13 4:08 ` Dan Williams
2012-06-21 10:09 ` Shaohua Li
2012-07-02 20:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604080328.104071243@kernel.org \
--to=shli@kernel.org \
--cc=axboe@kernel.dk \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@fusionio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.