From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>,
mingo@kernel.org, LKML <linux-kernel@vger.kernel.org>,
roland@kernel.org, efault@gmx.de, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: balance_cpu to consider other cpus in its group as target of (pinned) task migration
Date: Mon, 4 Jun 2012 17:11:30 +0530 [thread overview]
Message-ID: <20120604114130.GA3386@linux.vnet.ibm.com> (raw)
In-Reply-To: <1338800454.2448.71.camel@twins>
* Peter Zijlstra <peterz@infradead.org> [2012-06-04 11:00:54]:
> > Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
>
> Did vatsa write this patch?
I wrote the first version of the patch which Prashanth took, tested,
fixed a bug and is finally publishing it. So yes,
> If so, you forgot a From header, if not, wtf!?
it is missing the From header.
> OK, so previously we only pulled to ourselves,
That't not entirely true isn't it i.e this_cpu need not equal
smp_processor_id even before this change.
> now you make cpu x move
> from cpu y to cpu z. This changes the dynamic of the load-balancer, not
> a single word on that and its impact/ramifications.
The other possibility is for the right sibling cpus to do load balance
in the same domain (noting that it needs to pull a task from another
sched_group to itself and ignoring balance_cpu). That seemed like a more
invasive change than this patch. We'd be happy to try any other approach
you have in mind.
- vatsa
next prev parent reply other threads:[~2012-06-04 11:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 5:57 [PATCH] sched: balance_cpu to consider other cpus in its group as target of (pinned) task migration Prashanth Nageshappa
2012-06-04 9:00 ` Peter Zijlstra
2012-06-04 11:41 ` Srivatsa Vaddagiri [this message]
2012-06-04 11:49 ` Peter Zijlstra
2012-06-04 12:27 ` Srivatsa Vaddagiri
2012-06-04 11:51 ` Peter Zijlstra
2012-06-04 9:25 ` Mike Galbraith
2012-06-04 11:53 ` Peter Zijlstra
2012-06-04 12:47 ` Mike Galbraith
2012-06-04 13:07 ` Srivatsa Vaddagiri
2012-06-04 14:30 ` Mike Galbraith
2012-06-04 14:38 ` Srivatsa Vaddagiri
2012-06-04 14:41 ` Mike Galbraith
2012-06-04 15:00 ` Srivatsa Vaddagiri
2012-06-04 15:21 ` Peter Zijlstra
2012-06-04 15:25 ` Srivatsa Vaddagiri
2012-06-04 15:33 ` Peter Zijlstra
2012-06-04 15:46 ` Srivatsa Vaddagiri
2012-06-04 16:56 ` Mike Galbraith
2012-06-04 17:37 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604114130.GA3386@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prashanth@linux.vnet.ibm.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.