From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 4 Jun 2012 15:14:17 +0200
Subject: [U-Boot] [PATCH v2] Consolidate bootcount code into
	drivers/bootcount
In-Reply-To: <4FCCB21F.3080504@gmail.com>
References: <1338813539-28831-1-git-send-email-sr@denx.de>
	<4FCCB21F.3080504@gmail.com>
Message-ID: <201206041514.17201.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 04 June 2012 15:03:27 Rob Herring wrote:
> On 06/04/2012 07:38 AM, Stefan Roese wrote:
> > This patch moves all bootcount implementations into a common
> > directory: drivers/bootcount. The generic bootcount driver
> > is now usable not only by powerpc platforms, but others as well.
> > 
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> > Cc: Christian Riesch <christian.riesch@omicron.at>
> > Cc: Manfred Rudigier <manfred.rudigier@omicron.at>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Cc: Reinhard Meyer <reinhard.meyer@emk-elektronik.de>
> > ---
> > v2:
> > - Added CONFIG_BOOTCOUNT_LE to bootcount_davinci.c and enabled it
> > 
> >   in calimain.h to select little-endian accessors.
> 
> highbank is also LE.

Yes, sure. I could move those inline functions to a header, so that they can 
be used by the other "drivers" as well. Okay?

> Why don't you use __BYTE_ORDER rather than a new
> define?

Unfortunately not. There are LE platforms that use BE accessors for the 
bootcounter already (Davinci enbw_cmc). Mostly historical reasons I assume, 
since the original bootcount implementation was powerpc specific with those 
be32() functions.
 
Thanks,
Stefan