From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 4 Jun 2012 15:42:22 +0200 Subject: [U-Boot] [PATCH v2] Consolidate bootcount code into drivers/bootcount In-Reply-To: <4FCCB21F.3080504@gmail.com> References: <1338813539-28831-1-git-send-email-sr@denx.de> <4FCCB21F.3080504@gmail.com> Message-ID: <201206041542.22654.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Rob, On Monday 04 June 2012 15:03:27 Rob Herring wrote: > On 06/04/2012 07:38 AM, Stefan Roese wrote: > > This patch moves all bootcount implementations into a common > > directory: drivers/bootcount. The generic bootcount driver > > is now usable not only by powerpc platforms, but others as well. > > > > Signed-off-by: Stefan Roese > > Cc: Heiko Schocher > > Cc: Valentin Longchamp > > Cc: Christian Riesch > > Cc: Manfred Rudigier > > Cc: Mike Frysinger > > Cc: Rob Herring > > Cc: Reinhard Meyer > > --- > > v2: > > - Added CONFIG_BOOTCOUNT_LE to bootcount_davinci.c and enabled it > > > > in calimain.h to select little-endian accessors. > > highbank is also LE. Why don't you use __BYTE_ORDER rather than a new > define? I just noticed, that highbank only uses one lword as bootcounter storage. So CONFIG_SYS_BOOTCOUNT_SINGLEWORD needs to be set for the "generic" bootcount driver to work here. I'll fix this in v3 after a short delay for further review comments. Thanks, Stefan