From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: hold forcewake around ring hw init
Date: Mon, 4 Jun 2012 20:26:04 +0200
Message-ID: <20120604182604.GD30272@phenom.ffwll.local>
References: <8762b7qwgm.fsf@intel.com>
	<1338801495-30228-1-git-send-email-daniel.vetter@ffwll.ch>
	<4FCCAE7A.2030709@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id D55239E8FB
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  4 Jun 2012 11:24:38 -0700 (PDT)
Received: by wibhm14 with SMTP id hm14so2315479wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 04 Jun 2012 11:24:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <4FCCAE7A.2030709@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: eugeni.dodonov@intel.com
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, stable@vger.kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Jun 04, 2012 at 09:47:54AM -0300, Eugeni Dodonov wrote:
> On 06/04/2012 06:18 AM, Daniel Vetter wrote:
> >Empirical evidence suggests that we need to: On at least one ivb
> >machine when running the hangman i-g-t test, the rings don't properly
> >initialize properly - the RING_START registers seems to be stuck at
> >all zeros.
> >
> >Holding forcewake around this register init sequences makes chip reset
> >reliable again. Note that this is not the first such issue:
> >
> >commit f01db988ef6f6c70a6cc36ee71e4a98a68901229
> >Author: Sean Paul<seanpaul@chromium.org>
> >Date:   Fri Mar 16 12:43:22 2012 -0400
> >
> >     drm/i915: Add wait_for in init_ring_common
> >
> >added delay loops to make RING_START and RING_CTL initialization
> >reliable on the blt ring at boot-up. So I guess it won't hurt if we do
> >this unconditionally for all force_wake needing gpus.
> >
> >To avoid copy&pasting of the HAS_FORCE_WAKE check I've added a new
> >intel_info bit for that.
> >
> >v2: Fixup missing commas in static struct and properly handling the
> >error case in init_ring_common, both noticed by Jani Nikula.
> >
> >Cc: stable@vger.kernel.org
> >Reported-by: Yang Guang<guang.a.yang@intel.com>
> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50522
> >Signed-Off-by: Daniel Vetter<daniel.vetter@ffwll.ch>
> 
> The new .has_forcewake looks nice! Just one very tiny bikeshed below :).
> 
> Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Picked up for -fixes, thanks for the review.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48