Re: [PATCH 2/2] ACER: Add support for ambient light sensor

[Marek Vasut <marex@denx.de>]

Dear Corentin Chary,

> On Fri, Jun 1, 2012 at 7:11 PM, Marek Vasut <marex@denx.de> wrote:
> > This is the ambient light sensor found on Iconia W500.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: joeyli <jlee@suse.com>
> > ---

[...]

> > +static int __init acer_wmi_alsd_setup(void)
> > +{
> > +       int err;
> > +
> > +       err = acer_wmi_get_handle("ALSD", "ACPI0008", &alsd_handle);
> > +       if (err)
> > +               return err;
> 
> NACK !

What are you trying to achieve with such attitude? Are you trying to show off 
how much you can scream at someone new? I'd tell you some really harsh words and 
would turn my back on all this linux stuff if I wasn't used to people in kernel 
mailing lists having quite weird manners sometimes.

> This is a generic device, and should be handled by ACPI core
> (Samsung laptop have this too). See "ACPI ALS" on linux-acpi.

Saying this would be enough. Lee explained to me what this ACPI0008 means, I'm 
quite new to the ACPI land so pardon my ignorance here. But it then boils down 
to Lee's question, why wasn't the patch for ACPI ALS that was already proposed 
accepted? And what can be done to get it in?

Best regards,
Marek Vasut