All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Baron <jbaron@redhat.com>
Cc: pbonzini@redhat.com, Amos Kong <kongjianjun@gmail.com>,
	qemu-devel@nongnu.org, aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev()
Date: Tue, 5 Jun 2012 00:52:02 +0300	[thread overview]
Message-ID: <20120604215202.GA3193@redhat.com> (raw)
In-Reply-To: <20120604201556.GA2594@redhat.com>

On Mon, Jun 04, 2012 at 04:15:56PM -0400, Jason Baron wrote:
> On Sun, May 20, 2012 at 05:57:45PM +0800, Amos Kong wrote:
> > Start VM with 8 multiple-function block devs, hot-removing
> > those block devs by 'device_del ...' would cause qemu abort.
> > 
> > | (qemu) device_del virti0-0-0
> > | (qemu) **
> > |ERROR:qom/object.c:389:object_delete: assertion failed: (obj->ref == 0)
> > 
> > It's a regression introduced by commit 57c9fafe
> > 
> 
> I found a similar assertion where the parent reference isn't cleared,
> doing:
> 
> (qemu) device_add pci-bridge
> 
> in the monitor. I posted for patches for it under:
> 
> Subject: [Qemu-devel] [PATCH 0/2] pci: hotplug bridge fixes
> 
> It's still an issue with the current tree.
> 
> Thanks,
> 
> -Jason

I pushed your patches on my tree pci branch, care to test
there?

  reply	other threads:[~2012-06-04 21:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  2:15 [Qemu-devel] [PATCH] qom: fix refcounting in object_property_del_child() Amos Kong
2012-05-11  6:42 ` Paolo Bonzini
2012-05-11 14:52   ` Amos Kong
2012-05-11 14:57   ` [Qemu-devel] [PATCH] pci: unplug all devs of same slot once Amos Kong
2012-05-13  0:40     ` Amos Kong
2012-05-13 10:54     ` Michael S. Tsirkin
2012-05-14  7:55       ` Paolo Bonzini
2012-05-20  9:57     ` [Qemu-devel] [PATCH v3] pci: call object_unparent() before free_qdev() Amos Kong
2012-05-20 10:22       ` Michael S. Tsirkin
2012-06-04 20:15       ` Jason Baron
2012-06-04 21:52         ` Michael S. Tsirkin [this message]
2012-06-07 14:06           ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120604215202.GA3193@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jbaron@redhat.com \
    --cc=kongjianjun@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.