From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: comedi: cleanup comedi_recognize()
Date: Tue, 05 Jun 2012 11:01:05 +0000 [thread overview]
Message-ID: <20120605110105.GG4400@mwanda> (raw)
In-Reply-To: <20120524102851.GA4399@elgon.mountain>
On Tue, Jun 05, 2012 at 12:06:10PM +0200, walter harms wrote:
> Hi all,
> the patch is fine with me but i have a few basic questions:
>
> Why the (void *) at all ? it returns a name what is a const char *.
>
We're really returning a pointer to a private struct, it's just that
the first element on the struct always has to be a pointer to char *.
> A look at the structure also shows that this is a linked list, why
> using offset instead of driv->next ?
>
It's a different list.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-05 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 10:28 [patch] staging: comedi: cleanup comedi_recognize() Dan Carpenter
2012-05-24 10:57 ` Ian Abbott
2012-05-24 11:16 ` Dan Carpenter
2012-05-24 11:17 ` Ian Abbott
2012-06-05 10:06 ` walter harms
2012-06-05 11:01 ` Dan Carpenter [this message]
2012-06-06 9:28 ` Ian Abbott
2012-06-06 9:45 ` walter harms
2012-06-06 9:49 ` Dan Carpenter
2012-06-06 11:20 ` Ian Abbott
2012-06-06 12:28 ` walter harms
2012-06-06 14:11 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605110105.GG4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.