From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 0/8] Rework KERN_ Date: Tue, 5 Jun 2012 16:29:10 -0700 Message-ID: <20120605162910.caccb0d4.akpm@linux-foundation.org> References: <20120605142826.d92316a0.akpm@linux-foundation.org> <1338934303.5780.8.camel@joe2Laptop> <20120605151754.a794ac7c.akpm@linux-foundation.org> <1338936572.5780.29.camel@joe2Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by alsa0.perex.cz (Postfix) with ESMTP id 1039624339 for ; Wed, 6 Jun 2012 01:29:13 +0200 (CEST) In-Reply-To: <1338936572.5780.29.camel@joe2Laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Joe Perches Cc: devel@driverdev.osuosl.org, alsa-devel@alsa-project.org, Kay Sievers , Sievers , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kay@alsa-project.org, Linus Torvalds , linux-btrfs@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Tue, 05 Jun 2012 15:49:32 -0700 Joe Perches wrote: > On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote: > > On Tue, 05 Jun 2012 15:11:43 -0700 > > Joe Perches wrote: > > > > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote: > > > > Unfortunately the thing is part of the kernel ABI: > > > > > > > > echo "<4>foo" > /dev/kmsg > > > > > > Which works the same way it did before. > > > > I didn't say it didn't. > > > > What I did say is that echo "\0014">/dev/kmsg will subvert the intent > > of the new logging code. Or might. But you just ignored all that, > > forcing me to repeat myself, irritatedly. > > It works the same way before and after the patch. > > Any write to /dev/kmsg without a KERN_ > emits at (1 << 3) + KERN_DEFAULT. > > Writes with values >= 8 are emitted at > that level. What about writes starting with \001n? AFACIT, that will be stripped away and the printk level will be altered. This is new behavior. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:35521 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559Ab2FEX3L (ORCPT ); Tue, 5 Jun 2012 19:29:11 -0400 Date: Tue, 5 Jun 2012 16:29:10 -0700 From: Andrew Morton To: Joe Perches Cc: Linus Torvalds , linux-arm-kernel@lists.infradead.org, linux-btrfs@vger.kernel.org, Kay Sievers , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org, Kay Sievers Subject: Re: [PATCH 0/8] Rework KERN_ Message-Id: <20120605162910.caccb0d4.akpm@linux-foundation.org> In-Reply-To: <1338936572.5780.29.camel@joe2Laptop> References: <20120605142826.d92316a0.akpm@linux-foundation.org> <1338934303.5780.8.camel@joe2Laptop> <20120605151754.a794ac7c.akpm@linux-foundation.org> <1338936572.5780.29.camel@joe2Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Tue, 05 Jun 2012 15:49:32 -0700 Joe Perches wrote: > On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote: > > On Tue, 05 Jun 2012 15:11:43 -0700 > > Joe Perches wrote: > > > > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote: > > > > Unfortunately the thing is part of the kernel ABI: > > > > > > > > echo "<4>foo" > /dev/kmsg > > > > > > Which works the same way it did before. > > > > I didn't say it didn't. > > > > What I did say is that echo "\0014">/dev/kmsg will subvert the intent > > of the new logging code. Or might. But you just ignored all that, > > forcing me to repeat myself, irritatedly. > > It works the same way before and after the patch. > > Any write to /dev/kmsg without a KERN_ > emits at (1 << 3) + KERN_DEFAULT. > > Writes with values >= 8 are emitted at > that level. What about writes starting with \001n? AFACIT, that will be stripped away and the printk level will be altered. This is new behavior. From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org (Andrew Morton) Date: Tue, 5 Jun 2012 16:29:10 -0700 Subject: [PATCH 0/8] Rework KERN_ In-Reply-To: <1338936572.5780.29.camel@joe2Laptop> References: <20120605142826.d92316a0.akpm@linux-foundation.org> <1338934303.5780.8.camel@joe2Laptop> <20120605151754.a794ac7c.akpm@linux-foundation.org> <1338936572.5780.29.camel@joe2Laptop> Message-ID: <20120605162910.caccb0d4.akpm@linux-foundation.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 05 Jun 2012 15:49:32 -0700 Joe Perches wrote: > On Tue, 2012-06-05 at 15:17 -0700, Andrew Morton wrote: > > On Tue, 05 Jun 2012 15:11:43 -0700 > > Joe Perches wrote: > > > > > On Tue, 2012-06-05 at 14:28 -0700, Andrew Morton wrote: > > > > Unfortunately the thing is part of the kernel ABI: > > > > > > > > echo "<4>foo" > /dev/kmsg > > > > > > Which works the same way it did before. > > > > I didn't say it didn't. > > > > What I did say is that echo "\0014">/dev/kmsg will subvert the intent > > of the new logging code. Or might. But you just ignored all that, > > forcing me to repeat myself, irritatedly. > > It works the same way before and after the patch. > > Any write to /dev/kmsg without a KERN_ > emits at (1 << 3) + KERN_DEFAULT. > > Writes with values >= 8 are emitted at > that level. What about writes starting with \001n? AFACIT, that will be stripped away and the printk level will be altered. This is new behavior.