From: "John W. Linville" <linville@tuxdriver.com>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix race between tx path and ___ieee80211_stop_tx_ba_session
Date: Tue, 5 Jun 2012 15:00:08 -0400 [thread overview]
Message-ID: <20120605190008.GB1937@tuxdriver.com> (raw)
In-Reply-To: <CAGXE3d-TRGs=H_8HioSWr=J3zPWsoFRdOm5vc9MgSrbqZJMcUQ@mail.gmail.com>
On Wed, May 09, 2012 at 03:55:06PM +0200, Helmut Schaa wrote:
> On Wed, May 9, 2012 at 11:01 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Wed, 2012-05-09 at 10:56 +0200, Helmut Schaa wrote:
> >> ___ieee80211_stop_tx_ba_session first deletes the tx aggregation session
> >> timer and afterwards clears HT_AGG_STATE_OPERATIONAL. Hence, there is a
> >> small time window where the tx path can call mod_timer after
> >> del_timer_sync.
> >>
> >> When ieee80211_start_tx_ba_session runs before the timer the call to
> >> init_timer will cause a BUG_ON:
> >
> > This may have been fixed by my other patch where I check the state?
>
> I'll have to try but I'm not sure if these are two different issues ...
Did we get a final verdict on whether or not this patch is needed?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2012-06-05 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 8:56 [PATCH] mac80211: Fix race between tx path and ___ieee80211_stop_tx_ba_session Helmut Schaa
2012-05-09 9:01 ` Johannes Berg
2012-05-09 13:55 ` Helmut Schaa
2012-06-05 19:00 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605190008.GB1937@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.