From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH next] netfilter: NFQUEUE: don't xor src/dst ip address
Date: Wed, 6 Jun 2012 01:57:02 +0200 [thread overview]
Message-ID: <20120605235702.GC27222@1984> (raw)
In-Reply-To: <1338814434-15130-1-git-send-email-fw@strlen.de>
On Mon, Jun 04, 2012 at 02:53:54PM +0200, Florian Westphal wrote:
> because reply packets need to go to the same nfqueue, src/dst ip
> address were xor'd prior to jhash().
>
> However, this causes bad distribution for some workloads, e.g.
> flows a.b.1.{1,n} -> a.b.2.{1,n} all share the same hash value.
>
> Avoid this by hashing both. To get same hash for replies,
> first argument is the smaller address.
Applied. Thanks Florian.
prev parent reply other threads:[~2012-06-05 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 12:53 [PATCH next] netfilter: NFQUEUE: don't xor src/dst ip address Florian Westphal
2012-06-05 23:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605235702.GC27222@1984 \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.