All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Graeme Gregory <gg@slimlogic.co.uk>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: palmas: Slightly code change for better readability
Date: Wed, 6 Jun 2012 10:51:19 +0100	[thread overview]
Message-ID: <20120606095118.GB12405@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1338969050.4274.1.camel@phoenix>

On Wed, Jun 06, 2012 at 03:50:50PM +0800, Axel Lin wrote:

> if (id == PALMAS_REG_SMPS10) {
>         do something for the case id == PALMAS_REG_SMPS10;
> } else {
>         do something for the cases id != PALMAS_REG_SMPS10;
> }

If we're going to do this a switch statement would be even better...

      reply	other threads:[~2012-06-06  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06  7:50 [PATCH] regulator: palmas: Slightly code change for better readability Axel Lin
2012-06-06  9:51 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120606095118.GB12405@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=axel.lin@gmail.com \
    --cc=gg@slimlogic.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.