All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Ming Lei <Ming.Lei@riverbed.com>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: ext4 corruption during unexpected power cycle in the middle of writing
Date: Wed, 6 Jun 2012 14:55:26 -0400	[thread overview]
Message-ID: <20120606185526.GA10034@thunk.org> (raw)
In-Reply-To: <4FCEEB36.9010102@redhat.com>

On Wed, Jun 06, 2012 at 12:31:34AM -0500, Eric Sandeen wrote:
> Sort of.  You got:
> 
> > Free blocks count wrong (118366120, counted=76269471).
> > Fix? yes
> > 
> > Free inodes count wrong (30081013, counted=30081004).
> > Fix? yes
> 
> Those are the superblock counters, which aren't journaled - only the bg counters are logged via the journal, IIRC.

This has been partially addressed in e2fsprogs 1.42.3:

commit 2788cc879bbe667d28277e1d660b7e56514e5b30
Author: Andreas Dilger <adilger@whamcloud.com>
Date:   Tue Apr 24 16:22:48 2012 -0400

    e2fsck: quiet harmless inode/blocks errors
    
    Don't consider only an error in the superblock summary as incorrect.
    The kernel does not update this field except at unmount time, so
    don't print errors during a "-n" run if there is nothing else wrong.
    Any other unfixed errors will themselves mark the filesystem invalid.
    
    Signed-off-by: Andreas Dilger <adilger@whamcloud.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

So e2fsck -n will silence the warnings, and e2fsck -p/-y will just fix
them automatically, although they are still getting printed.  Maybe I
should just mark these messages as one where they just print the fact
that we are adjusting the free blocks count, and avoid using the word
"wrong" --- at least if the filesystem has a journal --- so the error
message isn't as scary/misleading.

						- Ted

      parent reply	other threads:[~2012-06-06 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06  5:24 ext4 corruption during unexpected power cycle in the middle of writing Ming Lei
2012-06-06  5:31 ` Eric Sandeen
2012-06-06  5:44   ` Ming Lei
2012-06-06 18:55   ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120606185526.GA10034@thunk.org \
    --to=tytso@mit.edu \
    --cc=Ming.Lei@riverbed.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.