From: Johan Hedberg <johan.hedberg@gmail.com>
To: Ido Yariv <ido@wizery.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] gattrib: Fix a premature response timer removal
Date: Thu, 7 Jun 2012 09:25:38 +0800 [thread overview]
Message-ID: <20120607012538.GA2953@x220> (raw)
In-Reply-To: <1338980175-14980-1-git-send-email-ido@wizery.com>
Hi Ido,
On Wed, Jun 06, 2012, Ido Yariv wrote:
> A timer is set when a response is expected. The timer is removed when
> data is received, regardless of whether or not the data is a response.
> As a result, the timer may be cleared even though a response was not
> received and there would be no way to detect a command timeout.
>
> Fix this by clearing the timer only after verifying a response was
> received.
> ---
> attrib/gattrib.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2012-06-07 1:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 10:56 [PATCH] gattrib: Fix a premature response timer removal Ido Yariv
2012-06-06 17:00 ` Vinicius Costa Gomes
2012-06-07 1:25 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607012538.GA2953@x220 \
--to=johan.hedberg@gmail.com \
--cc=ido@wizery.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.