Re: [PATCH] cgroup: make sure that decisions in __css_put are atomic

[Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Wed, Jun 06, 2012 at 03:31:19PM +0800, Li Zefan wrote:
> Salman Qazi wrote:
> 
> > __css_put is using atomic_dec on the ref count, and then
> > looking at the ref count to make decisions.  This is prone
> > to races, as someone else may decrement ref count between
> > our decrement and our decision.  Instead, we should base our
> > decisions on the value that we decremented the ref count to.
> > 
> > (This results in an actual race on Google's kernel which I
> > haven't been able to reproduce on the upstream kernel.  Having
> > said that, it's still incorrect by inspection).
> > 
> > Signed-off-by: Salman Qazi <sqazi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> 
> 
> Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> 
> Good catch! This patch should be backported for 3.4.

Applied to for-3.5-fixes w/ stable@ added.

Thanks.

-- 
tejun