All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch
Date: Thu, 07 Jun 2012 11:42:25 -0400	[thread overview]
Message-ID: <20120607154313.745979097@goodmis.org> (raw)
In-Reply-To: 20120607154222.443210802@goodmis.org

[-- Attachment #1: 0003-mips-remove-smp-reserve-lock.patch.patch --]
[-- Type: text/plain, Size: 1102 bytes --]

From: Thomas Gleixner <tglx@linutronix.de>

Instead of making the lock raw, remove it as it protects nothing.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable-rt@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 arch/mips/cavium-octeon/smp.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index efcfff4..86fce15 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -257,8 +257,6 @@ DEFINE_PER_CPU(int, cpu_state);
 
 extern void fixup_irqs(void);
 
-static DEFINE_SPINLOCK(smp_reserve_lock);
-
 static int octeon_cpu_disable(void)
 {
 	unsigned int cpu = smp_processor_id();
@@ -266,8 +264,6 @@ static int octeon_cpu_disable(void)
 	if (cpu == 0)
 		return -EBUSY;
 
-	spin_lock(&smp_reserve_lock);
-
 	cpu_clear(cpu, cpu_online_map);
 	cpu_clear(cpu, cpu_callin_map);
 	local_irq_disable();
@@ -277,8 +273,6 @@ static int octeon_cpu_disable(void)
 	flush_cache_all();
 	local_flush_tlb_all();
 
-	spin_unlock(&smp_reserve_lock);
-
 	return 0;
 }
 
-- 
1.7.10

  parent reply	other threads:[~2012-06-07 15:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07 15:42 [PATCH RT 0/4] [ANNOUNCE] 3.2.19-rt31-rc1 Steven Rostedt
2012-06-07 15:42 ` [PATCH RT 1/4] scsi: qla2xxx: Use local_irq_save_nort() in qla2x00_poll Steven Rostedt
2012-06-07 15:42 ` [PATCH RT 2/4] net,RT:REmove preemption disabling in netif_rx() Steven Rostedt
2012-06-07 15:42 ` Steven Rostedt [this message]
2012-06-07 15:42 ` [PATCH RT 4/4] Linux 3.2.19-rt31-rc1 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2012-06-07 15:51 [PATCH RT 0/4] [ANNOUNCE] 3.0.33-rt54-rc1 Steven Rostedt
2012-06-07 15:51 ` [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch Steven Rostedt
2012-06-07 17:50   ` David Daney
2012-06-07 18:56     ` Steven Rostedt
2012-06-07 19:08       ` David Daney
2012-06-07 19:32         ` Steven Rostedt
2012-06-07 19:47           ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120607154313.745979097@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.