From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [RFC PATCH 3/3] ASoC: tegra: add .stream_name to CPU DAIs
Date: Fri, 8 Jun 2012 07:01:40 +0800 [thread overview]
Message-ID: <20120607230139.GI14525@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1339024507-5096-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Wed, Jun 06, 2012 at 05:15:07PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> This is certainly required if the I2S and SPDIF controllers are converted
> to be CODECs, and is probably good practice irrespective.
>
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> I'm not sure if this is technically correct. It's certainly not required
> for the drivers to work correctly when they aren't CODECs, but doesn't
> appear to harm anything.
>
> Mark, Liam - what are your thoughts on this?
It's just generally best practice to provide a name for all streams, it
can be used for diagnostics if nothing else.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-07 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 23:15 [PATCH 1/3] ASoC: tegra: use DAI's not card's dev for dev_err Stephen Warren
[not found] ` <1339024507-5096-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-06 23:15 ` [PATCH 2/3] ASoC: tegra: use regmap more directly Stephen Warren
2012-06-06 23:15 ` [RFC PATCH 3/3] ASoC: tegra: add .stream_name to CPU DAIs Stephen Warren
[not found] ` <1339024507-5096-3-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-07 23:01 ` Mark Brown [this message]
2012-06-07 23:03 ` [PATCH 1/3] ASoC: tegra: use DAI's not card's dev for dev_err Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607230139.GI14525@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.