From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS.
Date: Thu, 7 Jun 2012 19:05:52 -0400 [thread overview]
Message-ID: <20120607230552.GL19839@thunk.org> (raw)
In-Reply-To: <1338779898-3146-1-git-send-email-tm@tao.ma>
On Mon, Jun 04, 2012 at 11:18:18AM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> 7990696 uses the ext4_{set,clear}_inode_flags() functions to change
> the i_flags automatically but fails to remove the error setting of
> i_flags. So we still have the problem of trashing state flags. So
> remove it.
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Good catch! Sorry that I missed it. I've taken this patch, thanks.
- Ted
prev parent reply other threads:[~2012-06-07 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 3:18 [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS Tao Ma
2012-06-07 23:05 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607230552.GL19839@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.