From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
khlebnikov@openvz.org, hughd@google.com,
kamezawa.hiroyu@jp.fujitsu.com, oleg@redhat.com,
stable@vger.kernel.org
Subject: Re: [patch 12/12] mm: correctly synchronize rss-counters at exit/exec
Date: Fri, 8 Jun 2012 03:05:20 +0200 [thread overview]
Message-ID: <20120608010520.GA25317@x4> (raw)
In-Reply-To: <CA+55aFyQUBXhjVLJH6Fhz9xnpfXZ=9Mej5ujt6ss7VUqT1g9Jg@mail.gmail.com>
On 2012.06.07 at 17:25 -0700, Linus Torvalds wrote:
> Ugh, looking more at the patch, I'm getting more and more convinces
> that it is pure and utter garbage.
>
> It does "sync_mm_rss(mm);" in mmput(), _after_ it has done the
> possibly final mmdrop(). WTF?
>
> This is crap, guys. Seriously. Stop playing russian rulette with this
> code. I think we need to revert *all* of the crazy rss games, unless
> Konstantin can show us some truly obviously correct fix.
>
> Sadly, I merged and pushed out the crap before I had rebooted and
> noticed this problem, so now it's in the wild. Can somebody please
> take a look at this asap?
You've somehow merged the wrong patch.
The correct version can be found here:
http://marc.info/?l=linux-kernel&m=133848759505805
--
Markus
next prev parent reply other threads:[~2012-06-08 1:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120607212114.E4F5AA02F8@akpm.mtv.corp.google.com>
[not found] ` <CA+55aFxOWR_h1vqRLAd_h5_woXjFBLyBHP--P8F7WsYrciXdmA@mail.gmail.com>
2012-06-08 0:25 ` [patch 12/12] mm: correctly synchronize rss-counters at exit/exec Linus Torvalds
2012-06-08 0:25 ` Linus Torvalds
2012-06-08 0:25 ` Linus Torvalds
2012-06-08 1:05 ` Markus Trippelsdorf [this message]
2012-06-08 1:18 ` Linus Torvalds
2012-06-08 1:18 ` Linus Torvalds
2012-06-08 12:18 ` Oleg Nesterov
2012-06-08 12:18 ` Oleg Nesterov
2012-06-11 10:25 ` Kamezawa Hiroyuki
2012-06-11 10:25 ` Kamezawa Hiroyuki
2012-06-08 1:16 ` Hugh Dickins
2012-06-08 1:19 ` Linus Torvalds
2012-06-08 1:19 ` Linus Torvalds
2012-06-08 1:19 ` Linus Torvalds
2012-06-08 5:28 ` Hugh Dickins
2012-06-08 10:20 ` Konstantin Khlebnikov
2012-06-08 10:20 ` Konstantin Khlebnikov
2012-06-08 12:24 ` Oleg Nesterov
2012-06-08 12:24 ` Oleg Nesterov
2012-06-08 13:29 ` Konstantin Khlebnikov
2012-06-08 13:29 ` Konstantin Khlebnikov
2012-06-08 17:01 ` Oleg Nesterov
2012-06-08 17:01 ` Oleg Nesterov
2012-06-09 9:43 ` [PATCH] " Konstantin Khlebnikov
2012-06-09 9:43 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608010520.GA25317@x4 \
--to=markus@trippelsdorf.de \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.