All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: kexec@lists.infradead.org, Simon Horman <horms@verge.net.au>
Cc: Jakub Jelinek <jakub@redhat.com>,
	"Suzuki K. Poulose" <suzuki@in.ibm.com>,
	Lingzhu Xiang <lxiang@redhat.com>
Subject: [PATCH] ppc/ppc64: Compile purgatory code with gcc option -msoft-float
Date: Fri, 8 Jun 2012 09:43:15 -0400	[thread overview]
Message-ID: <20120608134315.GA29791@redhat.com> (raw)

Recently we faced an issue on power7 machine where kernel hanged in purgatory.
Some investigation revealed that gcc is generating hardware FPU instructions.
I have been told we can't use it at this point of time and as kernel is
compiled with -msoft-float for ppc/ppc64, so should be purgatory (as it runs
inside kernel context).

Thanks to Jakub Jelinek and Lingzhu Xiang for debugging and coming up with
a fix for this issue.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Tested-by: Lingzhu Xiang <lxiang@redhat.com>
Tested-by: Suzuki K. Poulose <suzuki@in.ibm.com> 
---
 purgatory/arch/ppc/Makefile   |    2 ++
 purgatory/arch/ppc64/Makefile |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Index: kexec-tools/purgatory/arch/ppc64/Makefile
===================================================================
--- kexec-tools.orig/purgatory/arch/ppc64/Makefile	2012-02-20 14:45:25.000000000 -0500
+++ kexec-tools/purgatory/arch/ppc64/Makefile	2012-06-06 16:19:09.000696306 -0400
@@ -9,7 +9,7 @@ ppc64_PURGATORY_SRCS += purgatory/arch/p
 ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/crashdump_backup.c
 ppc64_PURGATORY_SRCS += purgatory/arch/ppc64/misc.S
 
-ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -mcall-aixdesc
+ppc64_PURGATORY_EXTRA_CFLAGS += -m64 -mcall-aixdesc -msoft-float
 ppc64_PURGATORY_EXTRA_ASFLAGS += -m64 -mcall-aixdesc
 ppc64_PURGATORY_EXTRA_LDFLAGS += -melf64ppc
 
Index: kexec-tools/purgatory/arch/ppc/Makefile
===================================================================
--- kexec-tools.orig/purgatory/arch/ppc/Makefile	2011-03-18 17:09:38.000000000 -0400
+++ kexec-tools/purgatory/arch/ppc/Makefile	2012-06-06 16:33:50.444406235 -0400
@@ -7,6 +7,8 @@ ppc_PURGATORY_SRCS += purgatory/arch/ppc
 ppc_PURGATORY_SRCS += purgatory/arch/ppc/purgatory-ppc.c
 ppc_PURGATORY_SRCS += purgatory/arch/ppc/console-ppc.c
 
+ppc_PURGATORY_EXTRA_CFLAGS += -msoft-float
+
 dist += purgatory/arch/ppc/Makefile $(ppc_PURGATORY_SRCS)		\
 	purgatory/arch/ppc/purgatory-ppc.h purgatory/arch/ppc/ppc_asm.h
 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

             reply	other threads:[~2012-06-08 13:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 13:43 Vivek Goyal [this message]
     [not found] ` <20120608134801.GZ24904@tucnak.redhat.com>
2012-06-08 14:39   ` [PATCH] ppc/ppc64: Compile purgatory code with gcc option -msoft-float Vivek Goyal
     [not found]     ` <20120608145113.GB24904@tucnak.redhat.com>
2012-06-08 15:19       ` Vivek Goyal
2012-06-08 17:36         ` Eric W. Biederman
2012-06-11  1:43         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120608134315.GA29791@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=horms@verge.net.au \
    --cc=jakub@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=lxiang@redhat.com \
    --cc=suzuki@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.