From: Dan Carpenter <dan.carpenter@oracle.com>
To: rjkm@metzlerbros.de
Cc: linux-media@vger.kernel.org
Subject: re: [media] DRX-K: Initial check-in
Date: Fri, 8 Jun 2012 16:46:35 +0300 [thread overview]
Message-ID: <20120608134635.GA19517@elgon.mountain> (raw)
Hello Ralph Metzler,
The patch 43dd07f758d8: "[media] DRX-K: Initial check-in" from Jul 3,
2011, leads to the following warning:
drivers/media/dvb/frontends/drxk_hard.c:2980 ADCSynchronization()
warn: suspicious bitop condition
2977 status = read16(state, IQM_AF_CLKNEG__A, &clkNeg);
2978 if (status < 0)
2979 goto error;
2980 if ((clkNeg | IQM_AF_CLKNEG_CLKNEGDATA__M) ==
2981 IQM_AF_CLKNEG_CLKNEGDATA_CLK_ADC_DATA_POS) {
IQM_AF_CLKNEG_CLKNEGDATA__M is 2.
IQM_AF_CLKNEG_CLKNEGDATA_CLK_ADC_DATA_POS is 0.
So this condition can never be true.
2982 clkNeg &= (~(IQM_AF_CLKNEG_CLKNEGDATA__M));
2983 clkNeg |=
2984 IQM_AF_CLKNEG_CLKNEGDATA_CLK_ADC_DATA_NEG;
2985 } else {
2986 clkNeg &= (~(IQM_AF_CLKNEG_CLKNEGDATA__M));
2987 clkNeg |=
2988 IQM_AF_CLKNEG_CLKNEGDATA_CLK_ADC_DATA_POS;
clkNeg |= 0; <-- doesn't make much sense to the unenlightened.
2989 }
I wrote a Smatch thing to find places that do x |= 0 inspired by the
above oddity and it finds several other places which do that:
drivers/media/dvb/frontends/drxk_hard.c:2525 GetQAMSignalToNoise() info: why not propagate 'status' from read16() instead of -22?
drivers/media/dvb/frontends/drxk_hard.c:2980 ADCSynchronization() warn: suspicious bitop condition
drivers/media/dvb/frontends/drxk_hard.c:2988 ADCSynchronization() warn: x |= 0
drivers/media/dvb/frontends/drxk_hard.c:3833 SetDVBT() warn: x |= 0
drivers/media/dvb/frontends/drxk_hard.c:3847 SetDVBT() warn: x |= 0
drivers/media/dvb/frontends/drxk_hard.c:3888 SetDVBT() warn: x |= 0
drivers/media/dvb/frontends/drxk_hard.c:3915 SetDVBT() warn: x |= 0
drivers/media/dvb/frontends/drxk_hard.c:3931 SetDVBT() warn: x |= 0
regards,
dan carpenter
next reply other threads:[~2012-06-08 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 13:46 Dan Carpenter [this message]
2012-06-10 19:42 ` [media] DRX-K: Initial check-in Ralph Metzler
2012-06-10 20:54 ` Dan Carpenter
2012-06-15 16:54 ` Ralph Metzler
2012-06-26 8:40 ` [patch] [media] drxk: fix a '&' vs '|' bug Dan Carpenter
2012-06-26 8:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608134635.GA19517@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=rjkm@metzlerbros.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.