All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Engelen <nouveau-xdCxd1SecUs@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH] More explicit error message when the kernel module has been configured 'noaccel' but the xorg configuration doesn't disable accelleration
Date: Sun, 10 Jun 2012 14:49:32 +0200	[thread overview]
Message-ID: <20120610124932.GA2822@bzzt.net> (raw)

I ran into this the other day - this more explicit error message might save someone some
head-scratching ;).
---
 src/nv_dma.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/nv_dma.c b/src/nv_dma.c
index d2a6d00..339b4fe 100644
--- a/src/nv_dma.c
+++ b/src/nv_dma.c
@@ -53,8 +53,13 @@ NVInitDma(ScrnInfoPtr pScrn)
 	ret = nouveau_object_new(device, 0, NOUVEAU_FIFO_CHANNEL_CLASS,
 				 data, size, &pNv->channel);
 	if (ret) {
-		xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
-			   "Error creating GPU channel: %d\n", ret);
+		if (ret == -ENODEV)
+			xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
+				   "'No such device' while creating GPU channel: perhaps you disabled "
+			           "accelleration in your module config but not in your X.Org config\n");
+		else
+			xf86DrvMsg(pScrn->scrnIndex, X_ERROR,
+				   "Error creating GPU channel: %d, %s\n", ret, strerror(-ret));
 		return FALSE;
 	}
 
-- 
1.7.10

                 reply	other threads:[~2012-06-10 12:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120610124932.GA2822@bzzt.net \
    --to=nouveau-xdcxd1secus@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.