From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
dchinner@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 17/27] ext4: Convert to new freezing mechanism
Date: Sun, 10 Jun 2012 23:13:40 -0400 [thread overview]
Message-ID: <20120611031340.GA29609@thunk.org> (raw)
In-Reply-To: <1338589841-9568-18-git-send-email-jack@suse.cz>
On Sat, Jun 02, 2012 at 12:30:31AM +0200, Jan Kara wrote:
> We remove most of frozen checks since upper layer takes care of blocking all
> writes. We have to handle protection in ext4_page_mkwrite() in a special way
> because we cannot use generic block_page_mkwrite(). Also we add a freeze
> protection to ext4_evict_inode() so that iput() of unlinked inode cannot modify
> a frozen filesystem (we cannot easily instrument ext4_journal_start() /
> ext4_journal_stop() with freeze protection because we are missing the
> superblock pointer in ext4_journal_stop() in nojournal mode).
>
> CC: linux-ext4@vger.kernel.org
> CC: "Theodore Ts'o" <tytso@mit.edu>
> BugLink: https://bugs.launchpad.net/bugs/897421
> Tested-by: Kamal Mostafa <kamal@canonical.com>
> Tested-by: Peter M. Petrakis <peter.petrakis@canonical.com>
> Tested-by: Dann Frazier <dann.frazier@canonical.com>
> Tested-by: Massimo Morana <massimo.morana@canonical.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
next prev parent reply other threads:[~2012-06-11 3:13 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 22:30 [Cluster-devel] [PATCH 00/27 v6] Fix filesystem freezing deadlocks Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` [PATCH 01/27] fb_defio: Push file_update_time() into fb_deferred_io_mkwrite() Jan Kara
2012-06-01 22:30 ` [PATCH 02/27] fs: Push file_update_time() into __block_page_mkwrite() Jan Kara
2012-06-01 22:30 ` [PATCH 03/27] ceph: Push file_update_time() into ceph_page_mkwrite() Jan Kara
2012-06-01 22:30 ` [PATCH 04/27] 9p: Push file_update_time() into v9fs_vm_page_mkwrite() Jan Kara
2012-06-01 22:30 ` [Cluster-devel] [PATCH 05/27] gfs2: Push file_update_time() into gfs2_page_mkwrite() Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` [PATCH 06/27] sysfs: Push file_update_time() into bin_page_mkwrite() Jan Kara
2012-06-01 22:30 ` [PATCH 07/27] mm: Update file times from fault path only if .page_mkwrite is not set Jan Kara
2012-06-01 22:30 ` [PATCH 08/27] mm: Make default vm_ops provide ->page_mkwrite handler Jan Kara
2012-06-01 22:30 ` [Ocfs2-devel] [PATCH 09/27] fs: Push mnt_want_write() outside of i_mutex Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` [PATCH 10/27] fat: " Jan Kara
2012-06-01 22:30 ` [PATCH 11/27] btrfs: " Jan Kara
2012-06-01 22:30 ` [PATCH 12/27] nfsd: " Jan Kara
2012-06-01 22:30 ` [PATCH 13/27] fs: Improve filesystem freezing handling Jan Kara
2012-06-01 22:30 ` [PATCH 14/27] fs: Add freezing handling to mnt_want_write() / mnt_drop_write() Jan Kara
2012-06-06 8:04 ` Dave Chinner
2012-06-06 15:16 ` Jan Kara
2012-06-01 22:30 ` [PATCH 15/27] fs: Skip atime update on frozen filesystem Jan Kara
2012-06-01 22:30 ` [PATCH 16/27] fs: Protect write paths by sb_start_write - sb_end_write Jan Kara
2012-06-01 22:30 ` [PATCH 17/27] ext4: Convert to new freezing mechanism Jan Kara
2012-06-11 3:13 ` Ted Ts'o [this message]
2012-06-01 22:30 ` [PATCH 18/27] xfs: Convert to new freezing code Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-05 4:15 ` Dave Chinner
2012-06-05 4:15 ` Dave Chinner
2012-06-05 8:43 ` Jan Kara
2012-06-05 8:43 ` Jan Kara
2012-06-01 22:30 ` [Ocfs2-devel] [PATCH 19/27] ocfs2: Convert to new freezing mechanism Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` [Cluster-devel] [PATCH 20/27] gfs2: " Jan Kara
2012-06-01 22:30 ` Jan Kara
2012-06-01 22:30 ` [PATCH 21/27] fuse: " Jan Kara
2012-06-01 22:30 ` [PATCH 22/27] ntfs: " Jan Kara
[not found] ` <1338589841-9568-1-git-send-email-jack-AlSwsSmVLrQ@public.gmane.org>
2012-06-01 22:30 ` [PATCH 23/27] nilfs2: " Jan Kara
2012-06-01 22:30 ` [PATCH 24/27] btrfs: " Jan Kara
2012-06-01 22:30 ` [PATCH 25/27] ext2: Implement freezing Jan Kara
2012-06-01 22:30 ` [PATCH 26/27] fs: Remove old freezing mechanism Jan Kara
2012-06-01 22:30 ` [PATCH 27/27] Documentation: Correct s_umount state for freeze_fs/unfreeze_fs Jan Kara
2012-06-09 6:29 ` [PATCH 00/27 v6] Fix filesystem freezing deadlocks Al Viro
2012-06-09 6:29 ` [Ocfs2-devel] " Al Viro
2012-06-09 6:29 ` Al Viro
2012-06-09 6:29 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2012-06-12 14:20 [Cluster-devel] [PATCH 00/27 v7] " Jan Kara
2012-06-12 14:20 ` [PATCH 17/27] ext4: Convert to new freezing mechanism Jan Kara
2012-04-16 16:13 [Cluster-devel] [PATCH 00/19 v5] Fix filesystem freezing deadlocks Jan Kara
2012-04-16 16:13 ` [PATCH 17/27] ext4: Convert to new freezing mechanism Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611031340.GA29609@thunk.org \
--to=tytso@mit.edu \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.