From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 03/27] ARM: shmobile: shareing extra gpio setting functions
Date: Mon, 11 Jun 2012 03:59:27 +0000 [thread overview]
Message-ID: <20120611035927.GE10170@linux-sh.org> (raw)
In-Reply-To: <87ipeyqzdr.wl%kuninori.morimoto.gx@renesas.com>
On Sun, Jun 10, 2012 at 08:52:03PM -0700, Kuninori Morimoto wrote:
> diff --git a/arch/arm/mach-shmobile/include/mach/gpio.h b/arch/arm/mach-shmobile/include/mach/gpio.h
> index de795b4..7c1e4ab 100644
> --- a/arch/arm/mach-shmobile/include/mach/gpio.h
> +++ b/arch/arm/mach-shmobile/include/mach/gpio.h
> @@ -13,6 +13,7 @@
> #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/sh_pfc.h>
> +#include <asm/io.h>
>
> #ifdef CONFIG_GPIOLIB
>
Minor nit, but please use linux/ headers when they are available.
next prev parent reply other threads:[~2012-06-11 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 3:52 [PATCH 03/27] ARM: shmobile: shareing extra gpio setting functions Kuninori Morimoto
2012-06-11 3:59 ` Paul Mundt [this message]
2012-06-11 8:00 ` Simon Horman
2012-06-11 10:00 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611035927.GE10170@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.