From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] e2fsck/tests: Add the regression test case for e2fsck.
Date: Mon, 11 Jun 2012 01:07:29 -0400 [thread overview]
Message-ID: <20120611050729.GA12379@thunk.org> (raw)
In-Reply-To: <1337238967-4704-3-git-send-email-tm@tao.ma>
On Thu, May 17, 2012 at 03:16:07PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> In commit "e2fsck: Let end_blk to be the maximum value of u32."
> we fix a bug where a normal fallocate will cause e2fsck complain.
> So add it to the regression test suite.
>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
I've changed the description of this commit to reflect the change in
how I propose to fix the problem....
- Ted
commit 8d12c46a22965179cae1e3b47778fdee5efeb513
Author: Tao Ma <boyu.mt@taobao.com>
Date: Sun Jun 10 23:56:30 2012 -0400
tests: add new test f_zero_extent_length
If all of the extents in the last extent tree block (ETB) in a
non-trivial extent tree contain uninitialized extents which are after
the end of the file as defined by i_size, the hueristics will
incorrectly estimate the last entry (and hence the node's e_len field)
in the last entry of each level of the extent tree.
As Tao Ma has noted, since e2fsck was requiring that the length
(e_len) field of interior nodes be non-zero, this was causing false
failures where e2fsck would declare that the extent tree was
corrupted.
This was fixed in commit 9c40d14841: "e2fsck: only check for
zero-length leaf extents". Add a regression test case to ensure that
this issue remains fixed.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2012-06-11 5:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 7:16 [PATCH 0/2 V2] Fix an e2fsck bug for fallocated extent Tao Ma
2012-05-17 7:16 ` [PATCH 1/2] e2fsck: Let end_blk to be the maximum value of u32 Tao Ma
2012-06-11 5:02 ` Ted Ts'o
2012-05-17 7:16 ` [PATCH 2/2] e2fsck/tests: Add the regression test case for e2fsck Tao Ma
2012-06-11 5:07 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611050729.GA12379@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.