From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ipack: remove pr_fmt definition.
Date: Mon, 11 Jun 2012 10:25:00 +0300 [thread overview]
Message-ID: <20120611072500.GT4400@mwanda> (raw)
In-Reply-To: <1339397797-17399-1-git-send-email-siglesias@igalia.com>
On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> As there is no pr_* function used here, pr_fmt is not needed.
>
Nah. What about if we decide to add some? Also there are actually
a couple pr_err() calls in there already.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-11 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 6:56 [PATCH] Staging: ipack: remove pr_fmt definition Samuel Iglesias Gonsalvez
2012-06-11 7:25 ` Dan Carpenter [this message]
2012-06-11 7:27 ` Dan Carpenter
2012-06-11 7:40 ` Samuel Iglesias Gonsálvez
2012-06-11 8:29 ` Dan Carpenter
2012-06-11 7:29 ` Samuel Iglesias Gonsálvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611072500.GT4400@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.