Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size

[Alon Levy <alevy@redhat.com>]

On Mon, Jun 11, 2012 at 09:42:28AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > +        if (d->fb_size < fb) {
> > +            d->fb_size = fb;
> > +        }
> > +        if (fb <= d->fb_size) {
> 
> This check doesn't make sense, it will always be true.

My mistake. Will remove the first three lines, so fb_size setting will
be required to get larger modes.

> 
> > +    if (qxl->fb_size_mb != -1 &&
> > +        qxl->fb_size_mb * 1024 * 1024 < qxl->vga.vram_size) {
> > +        qxl->fb_size = qxl->fb_size_mb * 1024 * 1024;
> > +    } else {
> > +        qxl->fb_size = VGA_RAM_SIZE;
> > +    }
> 
> Reminds me that I have some pending work to make vga ram size
> configurable which I should finish and repost ...
> 
> Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1
> 
> It probably makes sense to base this on top.

So I can rebase on top and send the patches, with the understanding you
will do any later changes and repost the whole thing.

> 
> > +        DEFINE_PROP_UINT32("fb_size_mb", PCIQXLDevice, fb_size_mb, -1),
> 
> Maybe also rename this to vgamem_mb for consistency with standard vga.

Will change.

> 
> cheers,
>   Gerd
>