From: Arnd Bergmann <arnd@arndb.de>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: bhutchings@solarflare.com, grundler@parisc-linux.org,
avi@redhat.com, mtosatti@redhat.com,
linux-net-drivers@solarflare.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
kvm@vger.kernel.org, takuya.yoshikawa@gmail.com
Subject: Re: [PATCH 1/4] drivers/net/ethernet/sfc: Add efx_ prefix to set_bit_le()
Date: Mon, 11 Jun 2012 14:09:15 +0000 [thread overview]
Message-ID: <201206111409.16093.arnd@arndb.de> (raw)
In-Reply-To: <20120611212901.2b4d0a17.yoshikawa.takuya@oss.ntt.co.jp>
On Monday 11 June 2012, Takuya Yoshikawa wrote:
>
> /* Set bit in a little-endian bitfield */
> -static inline void set_bit_le(unsigned nr, unsigned char *addr)
> +static inline void efx_set_bit_le(unsigned nr, unsigned char *addr)
> {
> addr[nr / 8] |= (1 << (nr % 8));
> }
>
> /* Clear bit in a little-endian bitfield */
> -static inline void clear_bit_le(unsigned nr, unsigned char *addr)
> +static inline void efx_clear_bit_le(unsigned nr, unsigned char *addr)
> {
> addr[nr / 8] &= ~(1 << (nr % 8));
> }
Hmm, any reason why we're not just using the existing non-atomic
__set_bit_le() here? I think the helpers in sfc and tulip can
just get removed if you use those.
Arnd
next prev parent reply other threads:[~2012-06-11 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 12:27 [PATCH 0/4] Introduce generic set_bit_le() Takuya Yoshikawa
2012-06-11 12:29 ` [PATCH 1/4] drivers/net/ethernet/sfc: Add efx_ prefix to set_bit_le() Takuya Yoshikawa
2012-06-11 14:09 ` Arnd Bergmann [this message]
2012-06-12 13:06 ` Takuya Yoshikawa
2012-06-12 13:12 ` Arnd Bergmann
2012-06-12 19:23 ` [PATCH] sfc: Use standard __{clear,set}_bit_le() functions Ben Hutchings
2012-06-12 19:23 ` Ben Hutchings
2012-06-11 12:30 ` [PATCH 2/4] drivers/net/ethernet/dec/tulip: Add tulip_ prefix to set_bit_le() Takuya Yoshikawa
2012-06-11 15:42 ` Grant Grundler
2012-06-11 12:31 ` [PATCH 3/4] bitops: Introduce generic set_bit_le() Takuya Yoshikawa
2012-06-11 14:10 ` Arnd Bergmann
2012-06-12 13:10 ` Takuya Yoshikawa
2012-06-11 12:32 ` [PATCH 4/4] KVM: Replace test_and_set_bit_le() in mark_page_dirty_in_slot() with set_bit_le() Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206111409.16093.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=grundler@parisc-linux.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mtosatti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.